Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp_vpnv4_asbr:mpls_table_check_entry needs to have run_and_expect type behavior #13901

Closed
donaldsharp opened this issue Jul 1, 2023 · 2 comments
Assignees
Labels
topotest_ci_bug triage Needs further investigation

Comments

@donaldsharp
Copy link
Member

The bgp_vpnv4_asbr test has a mpls_table_check_entry which establishes bgp neighbors and then ensures the vpnv4 prefix is found and then immediately checks to see that the label entries are installed, without any type of run_and_expect behavior at all. The test should be modified to have some basic run_and_expect behavior when you are crossing daemon boundaries to check for correct behavior. Tests may not run fast or they may run too fast and the label hasn't had a chance to be installed and processed in zebra.

This test is failing frequently in our CI and this is one of the reasons

@donaldsharp donaldsharp added the triage Needs further investigation label Jul 1, 2023
Copy link

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

@frrbot
Copy link

frrbot bot commented Dec 29, 2023

This issue will be automatically closed in the specified period unless there is further activity.

@frrbot frrbot bot closed this as completed Jan 5, 2024
@frrbot frrbot bot removed the autoclose label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topotest_ci_bug triage Needs further investigation
Projects
None yet
Development

No branches or pull requests

2 participants