bgpd: add support of traps for bgp4-mibv2 #14333

fdumontet6WIND · 2023-09-01T13:26:48Z

this pull request add the support of traps for bgp4-mibv2. It is
conformant to draft-ietf-idr-bgp4-mibv2-11.
bgp4V2EstablishedNotification and bgp4V2BackwardTransitionNotification.

since the MIB bgp4-mibv2 notification are redundant with MIB RFC4273
we added a 2 commands for avoiding conflicts.
bgp snmp traps rfc4273<enable|disable>
bgp snmp traps bgp4-mibv2<enable|disable>

NetDEF-CI · 2023-09-01T16:39:10Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13945/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13945/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 5
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 7
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 6
Ubuntu 18.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13945/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

<stdin>:69: trailing whitespace.
       "Specify unusing rfc4273 traps\n") 
<stdin>:95: trailing whitespace.
       "Specify unusing bgp4-mibv2 traps\n") 
<stdin>:121: trailing whitespace.
		 BGP_SNMP_TRAPS_BGP4MIBV2_ENABLED);	
<stdin>:166: trailing whitespace.
#define BGP_SNMP_TRAPS_RFC4273_ENABLED (1 << 0) 
<stdin>:214: trailing whitespace.
	{ 6, { 1, 2, 1, BGP4V2_PEER_STATE, 1, 4 } },  
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
Report for agentx.c | 2 issues
===============================================
< ERROR: trailing whitespace
< #206: FILE: /tmp/f1-798332/agentx.c:206:
Report for bgpd.h | 4 issues
===============================================
< ERROR: space required after that ',' (ctx:VxV)
< #835: FILE: /tmp/f1-798332/bgpd.h:835:
< ERROR: "foo * bar" should be "foo *bar"
< #2701: FILE: /tmp/f1-798332/bgpd.h:2701:
Report for bgp_fsm.c | 4 issues
===============================================
< ERROR: "foo * bar" should be "foo *bar"
< #48: FILE: /tmp/f1-798332/bgp_fsm.c:48:
< ERROR: "foo * bar" should be "foo *bar"
< #49: FILE: /tmp/f1-798332/bgp_fsm.c:49:
Report for bgp_fsm.h | 2 issues
===============================================
< ERROR: "foo * bar" should be "foo *bar"
< #147: FILE: /tmp/f1-798332/bgp_fsm.h:147:
Report for bgp_snmp_bgp4v2.c | 10 issues
===============================================
< ERROR: trailing whitespace
< #781: FILE: /tmp/f1-798332/bgp_snmp_bgp4v2.c:781:
< ERROR: trailing whitespace
< #794: FILE: /tmp/f1-798332/bgp_snmp_bgp4v2.c:794:
< ERROR: trailing whitespace
< #799: FILE: /tmp/f1-798332/bgp_snmp_bgp4v2.c:799:
< ERROR: trailing whitespace
< #808: FILE: /tmp/f1-798332/bgp_snmp_bgp4v2.c:808:
< ERROR: trailing whitespace
< #1482: FILE: /tmp/f1-798332/bgp_snmp_bgp4v2.c:1482:
Report for bgp_snmp.c | 18 issues
===============================================
< ERROR: space required before the open brace '{'
< #51: FILE: /tmp/f1-798332/bgp_snmp.c:51:
< ERROR: space required before the open brace '{'
< #56: FILE: /tmp/f1-798332/bgp_snmp.c:56:
< WARNING: unnecessary whitespace before a quoted newline
< #62: FILE: /tmp/f1-798332/bgp_snmp.c:62:
< ERROR: space required before the open brace '{'
< #77: FILE: /tmp/f1-798332/bgp_snmp.c:77:
< ERROR: space required before the open brace '{'
< #82: FILE: /tmp/f1-798332/bgp_snmp.c:82:
< WARNING: unnecessary whitespace before a quoted newline
< #88: FILE: /tmp/f1-798332/bgp_snmp.c:88:
< ERROR: trailing whitespace
< #100: FILE: /tmp/f1-798332/bgp_snmp.c:100:
< ERROR: spaces required around that '?' (ctx:VxE)
< #108: FILE: /tmp/f1-798332/bgp_snmp.c:108:
< ERROR: spaces required around that '?' (ctx:VxE)
< #112: FILE: /tmp/f1-798332/bgp_snmp.c:112:
Report for bgp_snmp.h | 2 issues
===============================================
< ERROR: trailing whitespace
< #20: FILE: /tmp/f1-798332/bgp_snmp.h:20:

NetDEF-CI · 2023-09-01T17:04:49Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13944/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-13944/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13944/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13944/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-13944/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13944/artifact/TOPO1DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13944/artifact/TOPO1DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13944/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check

NetDEF-CI · 2023-09-01T17:17:21Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13946/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 3
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check

NetDEF-CI · 2023-09-03T22:01:19Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13962/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-13962/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13962/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13962/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13962/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 8

NetDEF-CI · 2023-09-04T09:50:52Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/config.status/config.status Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/ErrorLog/ Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/config.log/config.log.gz Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/frr.xref.xz/frr.xref.xz Redhat 9 amd64 build: No useful log found

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/config.status/config.status Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/ErrorLog/ Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/config.log/config.log.gz Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/frr.xref.xz/frr.xref.xz Redhat 8 amd64 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

Successful on other platforms/tests

FreeBSD 11 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/config.status/config.status Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/ErrorLog/ Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/config.log/config.log.gz Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/RH9BUILD/frr.xref.xz/frr.xref.xz Redhat 9 amd64 build: No useful log found

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/config.status/config.status Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/ErrorLog/ Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/config.log/config.log.gz Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/REDHAT8/frr.xref.xz/frr.xref.xz Redhat 8 amd64 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13967/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

<stdin>:37: trailing whitespace.
       "Specify unusing rfc4273 traps\n") 
<stdin>:63: trailing whitespace.
       "Specify unusing bgp4-mibv2 traps\n") 
<stdin>:89: trailing whitespace.
		 BGP_SNMP_TRAPS_BGP4MIBV2_ENABLED);	
<stdin>:253: trailing whitespace.
static struct trap_object bgpv2TrapBackListv6[] = 
<stdin>:315: trailing whitespace.
	
warning: 5 lines add whitespace errors.
Report for bgpd.h | 2 issues
===============================================
< ERROR: space required after that ',' (ctx:VxV)
< #835: FILE: /tmp/f1-907560/bgpd.h:835:
Report for bgp_snmp_bgp4v2.c | 6 issues
===============================================
< ERROR: trailing whitespace
< #801: FILE: /tmp/f1-907560/bgp_snmp_bgp4v2.c:801:
< ERROR: that open brace { should be on the previous line
< #802: FILE: /tmp/f1-907560/bgp_snmp_bgp4v2.c:802:
< ERROR: trailing whitespace
< #1475: FILE: /tmp/f1-907560/bgp_snmp_bgp4v2.c:1475:
Report for bgp_snmp.c | 6 issues
===============================================
< WARNING: unnecessary whitespace before a quoted newline
< #62: FILE: /tmp/f1-907560/bgp_snmp.c:62:
< WARNING: unnecessary whitespace before a quoted newline
< #88: FILE: /tmp/f1-907560/bgp_snmp.c:88:
< ERROR: trailing whitespace
< #100: FILE: /tmp/f1-907560/bgp_snmp.c:100:

ton31337

Documentation is missing
Lots of styling/formatting issues
We should write a test for this new stuff

ton31337 · 2023-09-04T10:02:35Z

bgpd/bgp_fsm.c

@@ -1309,7 +1309,6 @@ void bgp_fsm_change_status(struct peer *peer, enum bgp_fsm_status status)
 	if (peer->connection->ostatus == Established &&
 	    peer->connection->status != Established)
 		hook_call(peer_backward_transition, peer);
-


Can we drop this change?

ton31337 · 2023-09-04T10:03:20Z

bgpd/bgp_snmp.c

+				BGP_SNMP_TRAPS_RFC4273_ENABLED);
+		return CMD_SUCCESS;
+	}
+	if (off) {


taken into account

ton31337 · 2023-09-04T10:03:38Z

bgpd/bgp_snmp.c

+		return CMD_SUCCESS;
+	}
+
+	vty_out(vty, "bgp traps configuration must be specified \n");


whitespace after specified is not needed

By the way, is this even a valid entry point here? Because enable/disable is mandatory.

ton31337 · 2023-09-04T10:04:33Z

bgpd/bgp_snmp.c

+       "bgp snmp traps bgp4-mibv2<enable$on|disable$off>",
+       BGP_STR
+       "Configure BGP SNMP\n"
+       "Configure SNMP traps for BGP \n"


Please drop whitespace before \n.

tacken into account

ton31337 · 2023-09-04T10:04:37Z

bgpd/bgp_snmp.c

+       BGP_STR
+       "Configure BGP SNMP\n"
+       "Configure SNMP traps for BGP \n"
+       "Configure use of bgp4-mibv2 SNMP traps for BGP \n"


Please drop whitespace before \n.

taken into account

bgpd/bgp_snmp.c

ton31337 · 2023-09-04T10:09:29Z

bgpd/bgp_snmp_bgp4v2.c

+		break;
+	default:
+		return 0;
+		;


Drop this line please.

ton31337 · 2023-09-04T10:10:07Z

bgpd/bgp_snmp_bgp4v2.c

+		break;
+	default:
+		return 0;
+		;


Drop this line please.

ton31337 · 2023-09-04T10:10:11Z

bgpd/bgp_snmp_bgp4v2.c

+	return 0;
+}
+
+


Drop this line please.

ton31337 · 2023-09-04T10:10:24Z

bgpd/bgp_snmp_bgp4v2.h

@@ -11,10 +11,17 @@

 /* bgp4V2 */
 #define BGP4V2MIB 1, 3, 6, 1, 3, 5, 1
-


Drop this change please.

NetDEF-CI · 2023-09-04T12:25:14Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13969/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13969/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 1
Debian 9 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 3

NetDEF-CI · 2023-09-04T12:27:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13968/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13968/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-13968/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13968/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13968/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-13968/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13968/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

<stdin>:37: trailing whitespace.
       "Specify unusing rfc4273 traps\n") 
<stdin>:63: trailing whitespace.
       "Specify unusing bgp4-mibv2 traps\n") 
<stdin>:89: trailing whitespace.
		 BGP_SNMP_TRAPS_BGP4MIBV2_ENABLED);	
<stdin>:253: trailing whitespace.
static struct trap_object bgpv2TrapBackListv6[] = { 
<stdin>:315: trailing whitespace.
	
warning: 5 lines add whitespace errors.
Report for bgpd.h | 2 issues
===============================================
< ERROR: space required after that ',' (ctx:VxV)
< #835: FILE: /tmp/f1-982485/bgpd.h:835:
Report for bgp_snmp_bgp4v2.c | 4 issues
===============================================
< ERROR: trailing whitespace
< #801: FILE: /tmp/f1-982485/bgp_snmp_bgp4v2.c:801:
< ERROR: trailing whitespace
< #1475: FILE: /tmp/f1-982485/bgp_snmp_bgp4v2.c:1475:
Report for bgp_snmp.c | 6 issues
===============================================
< WARNING: unnecessary whitespace before a quoted newline
< #62: FILE: /tmp/f1-982485/bgp_snmp.c:62:
< WARNING: unnecessary whitespace before a quoted newline
< #88: FILE: /tmp/f1-982485/bgp_snmp.c:88:
< ERROR: trailing whitespace
< #100: FILE: /tmp/f1-982485/bgp_snmp.c:100:

NetDEF-CI · 2023-09-04T19:49:48Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13980/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-13980/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13980/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13980/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 8
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check

NetDEF-CI · 2023-09-04T19:54:46Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13981/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-13981/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13981/artifact/TOPO1U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13981/artifact/TOPO1U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 8
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Debian 10 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check

fdumontet6WIND · 2023-09-04T20:54:05Z

CI:RERUN

NetDEF-CI · 2023-09-05T04:55:17Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13984/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 9: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check

riw777

one question on the config, otherwise looks okay

riw777 · 2023-09-05T12:31:25Z

bgpd/bgp_snmp.c

+	vty_out(vty, "traps rfc4273 %s\n",
+		CHECK_FLAG(bgp_snmp_traps_flags,
+			   BGP_SNMP_TRAPS_RFC4273_ENABLED) ?
+		"enabled":"disabled");


I think that it only happening when the snmp module is loaded is kindof orthogonal, though ... when the configuration is generated, it should only create a line of config if the value is set to something other than the default (?)

fdumontet6WIND · 2023-09-05T13:05:26Z

doc added
test will be provided later

NetDEF-CI · 2023-09-05T16:49:06Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14011/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14011/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-14011/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14011/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 3: Incomplete

(check logs for details)

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 1: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 5

fdumontet6WIND · 2023-10-19T07:34:10Z

ci:rerun

ton31337 · 2023-10-19T15:36:18Z

doc/user/snmptrap.rst

+dealing with up/down events and state transition. The user has the
+possibility to select the MIB he wants to receive traps from:
+
+.. clicmd:: [no] bgp snmp traps <rfc4273|bgp4-mibv2>


We don't use [no] in documentation, please drop it.

taken into account

ton31337 · 2023-10-19T15:36:36Z

doc/user/snmptrap.rst

+
+.. clicmd:: [no] bgp snmp traps <rfc4273|bgp4-mibv2>
+
+By default, all traps are enabled and sent.


All traps or only rfc4273?

taken into account

ton31337 · 2023-10-19T15:37:36Z

tests/topotests/bgp_snmp_bgp4v2mib/test_bgp_snmp_bgp4v2mib.py

+    topotest.sleep(1)
+    r2.vtysh_cmd("conf\nbgp snmp traps bgp4-mibv2")
+    r2.vtysh_cmd("conf\nno bgp snmp traps rfc4273")
+    topotest.sleep(1)


taken into account

ton31337 · 2023-10-19T15:37:59Z

tests/topotests/bgp_snmp_bgp4v2mib/test_bgp_snmp_bgp4v2mib.py

+    r2.vtysh_cmd("conf\nno bgp snmp traps rfc4273")
+    topotest.sleep(1)
+    r1.vtysh_cmd("clear bgp *")
+    topotest.sleep(1)


Here too, this isn't a deterministic approach...

taken into account

ton31337

A couple nits for documentation is still missing.

ton31337 · 2023-10-19T15:40:45Z

Also, please update the commits to reflect the changed commands. For instance, cdf08fd here old commands listed (enable/disable).

fdumontet6WIND · 2023-10-20T10:53:48Z

ci:rerun

ton31337

LGTM

ton31337 · 2023-10-23T08:39:15Z

ci:rerun CI stuck somewhere...

fdumontet6WIND · 2023-10-23T13:30:14Z

ci:rerun failure not related to Pull Request

fdumontet6WIND · 2023-10-23T18:37:00Z

ci:rerun

idryzhov · 2023-10-24T08:03:53Z

lib/agentx.c

@@ -24,6 +24,7 @@
 XREF_SETUP();

 DEFINE_HOOK(agentx_enabled, (), ());
+DEFINE_HOOK(bgp_snmp_traps_config_write, (struct vty *vty), (vty));


This is wrong to define a BGP-related hook in the common library code. Why does BGP trap config depends on agentx being enabled anyway? You can use bgp snmp traps bgp4-mibv2 and it won't be in the running config until you enable agentx. It shouldn't work like that.

Good catch @idryzhov 👍

taken into account

riw777

looks good ... waiting on other comments

There is no cli command to prevent the router to send traps implemented in the rfc4273. If not done, when introducing the traps from bgp4v2mib, traps will be send for each of the two mibs: there will be redundancy in the sent information. Add a new command: - [no] bgp snmp traps rfc4273 Using this command will allow or not the notification of the following traps: - bgpEstablishedNotification - bgpBackwardTransNotification Signed-off-by: Francois Dumontet <[email protected]>

This commit add the support of traps for bgp4-mibv2. It is conformant to draft-ietf-idr-bgp4-mibv2-11. The following traps are supported: - bgp4V2EstablishedNotification - bgp4V2BackwardTransitionNotification Signed-off-by: Francois Dumontet <[email protected]>

There is no command to choose to send or not the bgp4-mibv2 traps. Since the MIB bgp4-mibv2 notification are redundant with MIB RFC4273 we added a command: - [no] bgp snmp traps bgp4-mibv2 By default, the bgp4-mibv2 traps will be disabled, to prevent from redundancy. Signed-off-by: Francois Dumontet <[email protected]>

update traps documentation Signed-off-by: Philippe Guibert <[email protected]>

Signed-off-by: Francois Dumontet <[email protected]>

frrbot bot added the bgp label Sep 1, 2023

github-actions bot added master size/L labels Sep 1, 2023

fdumontet6WIND force-pushed the bgp4v2_snmp branch 2 times, most recently from f83618e to 8479780 Compare September 1, 2023 13:30

fdumontet6WIND force-pushed the bgp4v2_snmp branch from 8479780 to d8e17b8 Compare September 3, 2023 19:03

fdumontet6WIND force-pushed the bgp4v2_snmp branch 3 times, most recently from 6438f72 to 9b0ed1c Compare September 4, 2023 09:46

ton31337 requested changes Sep 4, 2023

View reviewed changes

fdumontet6WIND force-pushed the bgp4v2_snmp branch 2 times, most recently from 1d38546 to 13668f0 Compare September 4, 2023 17:06

riw777 reviewed Sep 5, 2023

View reviewed changes

fdumontet6WIND force-pushed the bgp4v2_snmp branch from 13668f0 to def1ebe Compare September 5, 2023 12:57

frrbot bot added the documentation label Sep 5, 2023

github-actions bot added the rebase PR needs rebase label Sep 5, 2023

fdumontet6WIND force-pushed the bgp4v2_snmp branch from def1ebe to 1aefb13 Compare September 5, 2023 13:03

fdumontet6WIND force-pushed the bgp4v2_snmp branch from fb8d166 to e114ce9 Compare October 18, 2023 17:18

fdumontet6WIND requested a review from ton31337 October 19, 2023 07:34

ton31337 reviewed Oct 19, 2023

View reviewed changes

fdumontet6WIND force-pushed the bgp4v2_snmp branch from e114ce9 to 5be7383 Compare October 19, 2023 16:53

fdumontet6WIND requested a review from ton31337 October 19, 2023 16:57

ton31337 approved these changes Oct 23, 2023

View reviewed changes

idryzhov requested changes Oct 24, 2023

View reviewed changes

riw777 approved these changes Oct 24, 2023

View reviewed changes

fdumontet6WIND added 8 commits October 24, 2023 17:16

doc: [no] bgp snmp traps <rfc4273|bgp4-mibv2>

7552dba

update traps documentation Signed-off-by: Philippe Guibert <[email protected]>

tests: lib add support of snmptrapd daemon

6261c2b

Signed-off-by: Francois Dumontet <[email protected]>

tests: add bgp4 MIB traps test

50c95b6

Signed-off-by: Francois Dumontet <[email protected]>

tests: add bgp4v2 MIB traps test

9d14c70

Signed-off-by: Francois Dumontet <[email protected]>

bgpd: fix new Formatting / Styling warning

ccef545

Signed-off-by: Francois Dumontet <[email protected]>

fdumontet6WIND force-pushed the bgp4v2_snmp branch from 5be7383 to ccef545 Compare October 24, 2023 15:18

fdumontet6WIND requested a review from idryzhov October 24, 2023 15:20

idryzhov approved these changes Oct 24, 2023

View reviewed changes

ton31337 merged commit 26373fb into FRRouting:master Oct 24, 2023
79 checks passed

		@@ -11,10 +11,17 @@

		/* bgp4V2 */
		#define BGP4V2MIB 1, 3, 6, 1, 3, 5, 1


		.. clicmd:: [no] bgp snmp traps <rfc4273\|bgp4-mibv2>

		By default, all traps are enabled and sent.

bgpd: add support of traps for bgp4-mibv2 #14333

bgpd: add support of traps for bgp4-mibv2 #14333

Conversation

fdumontet6WIND commented Sep 1, 2023 • edited Loading

NetDEF-CI commented Sep 1, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Sep 1, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Sep 1, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Sep 3, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Sep 4, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

ton31337 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NetDEF-CI commented Sep 4, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Sep 4, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Sep 4, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Sep 4, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

fdumontet6WIND commented Sep 4, 2023

NetDEF-CI commented Sep 5, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

riw777 left a comment

fdumontet6WIND commented Sep 1, 2023 •

edited

Loading

NetDEF-CI commented Sep 1, 2023 •

edited

Loading

NetDEF-CI commented Sep 1, 2023 •

edited

Loading

NetDEF-CI commented Sep 1, 2023 •

edited

Loading

NetDEF-CI commented Sep 3, 2023 •

edited

Loading

NetDEF-CI commented Sep 4, 2023 •

edited

Loading

NetDEF-CI commented Sep 4, 2023 •

edited

Loading

NetDEF-CI commented Sep 4, 2023 •

edited

Loading

NetDEF-CI commented Sep 4, 2023 •

edited

Loading

NetDEF-CI commented Sep 4, 2023 •

edited

Loading

NetDEF-CI commented Sep 5, 2023 •

edited

Loading

NetDEF-CI commented Sep 5, 2023 •

edited

Loading