Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two test cleanups #14367

Merged
merged 2 commits into from
Nov 26, 2024
Merged

two test cleanups #14367

merged 2 commits into from
Nov 26, 2024

Conversation

donaldsharp
Copy link
Member

see individual commits but some minor tweaking to fix the occassional error we are seeing

@frrbot frrbot bot added bugfix tests Topotests, make check, etc labels Sep 7, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 7, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-14043/test

Topology Tests failed for Topotests debian 10 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-14043/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-14043/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5U18I386/TopotestDetails/

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-14043/test

Topology Tests failed for Topotests debian 10 amd64 part 9:

2023/09/07-13:37:04  ============================= test session starts ==============================
2023/09/07-13:37:04  platform linux -- Python 3.8.9, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /root/pytest_exabgp3/bin/python3.8
2023/09/07-13:37:04  cachedir: .pytest_cache
2023/09/07-13:37:04  metadata: {'Python': '3.8.9', 'Platform': 'Linux-4.19.0-24-amd64-x86_64-with-glibc2.28', 'Packages': {'pytest': '6.2.5', 'pluggy': '1.0.0'}, 'Plugins': {'xdist': '3.2.1', 'html': '3.2.0', 'metadata': '2.0.4'}}
2023/09/07-13:37:04  rootdir: /root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ2-TOPO9DEB10AMD64/topotests, configfile: pytest.ini
2023/09/07-13:37:04  plugins: xdist-3.2.1, html-3.2.0, metadata-2.0.4
2023/09/07-13:37:08  collecting ... collected 304 items / 1 error / 303 selected
2023/09/07-13:37:08  
2023/09/07-13:37:08  - generated xml file: /root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ2-TOPO9DEB10AMD64/topotests.xml -
2023/09/07-13:37:08  =========================== short test summary info ============================
2023/09/07-13:37:08  ERROR ospfapi/test_ospf_clientapi.py
2023/09/07-13:37:08  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
2023/09/07-13:37:08  =============================== 1 error in 4.09s ===============================

see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14043/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9:

2023/09/07-13:36:22  ============================= test session starts ==============================
2023/09/07-13:36:22  platform linux -- Python 3.8.9, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /root/pytest_exabgp3/bin/python3.8
2023/09/07-13:36:22  cachedir: .pytest_cache
2023/09/07-13:36:22  metadata: {'Python': '3.8.9', 'Platform': 'Linux-5.4.0-148-generic-i686-with-glibc2.27', 'Packages': {'pytest': '6.2.5', 'pluggy': '1.0.0'}, 'Plugins': {'xdist': '3.2.1', 'html': '3.2.0', 'metadata': '2.0.4'}}
2023/09/07-13:36:22  rootdir: /root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ2-TOPO9U18I386/topotests, configfile: pytest.ini
2023/09/07-13:36:22  plugins: xdist-3.2.1, html-3.2.0, metadata-2.0.4
2023/09/07-13:36:26  collecting ... collected 304 items / 1 error / 303 selected
2023/09/07-13:36:26  
2023/09/07-13:36:26  - generated xml file: /root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ2-TOPO9U18I386/topotests.xml -
2023/09/07-13:36:26  =========================== short test summary info ============================
2023/09/07-13:36:26  ERROR ospfapi/test_ospf_clientapi.py
2023/09/07-13:36:26  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
2023/09/07-13:36:26  =============================== 1 error in 4.22s ===============================

see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-14043/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9:

2023/09/07-13:36:19  ============================= test session starts ==============================
2023/09/07-13:36:19  platform linux -- Python 3.8.9, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /root/pytest_exabgp3/bin/python3.8
2023/09/07-13:36:19  cachedir: .pytest_cache
2023/09/07-13:36:19  metadata: {'Python': '3.8.9', 'Platform': 'Linux-5.4.0-148-generic-x86_64-with-glibc2.27', 'Packages': {'pytest': '6.2.5', 'pluggy': '1.0.0'}, 'Plugins': {'xdist': '3.2.1', 'html': '3.2.0', 'metadata': '2.0.4'}}
2023/09/07-13:36:19  rootdir: /root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ2-TOPO9U18AMD64/topotests, configfile: pytest.ini
2023/09/07-13:36:19  plugins: xdist-3.2.1, html-3.2.0, metadata-2.0.4
2023/09/07-13:36:22  collecting ... collected 304 items / 1 error / 303 selected
2023/09/07-13:36:22  
2023/09/07-13:36:22  - generated xml file: /root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ2-TOPO9U18AMD64/topotests.xml -
2023/09/07-13:36:22  =========================== short test summary info ============================
2023/09/07-13:36:22  ERROR ospfapi/test_ospf_clientapi.py
2023/09/07-13:36:22  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
2023/09/07-13:36:22  =============================== 1 error in 3.11s ===============================

see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14043/artifact/TOPO5U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Static analyzer (clang)
  • Addresssanitizer topotests part 8
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 4

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Sep 12, 2023

failure doesn't look related ... let's try again
ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 12, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-14124/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5U18I386/TopotestDetails/

Topotests debian 10 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-14124/test

Topology Tests failed for Topotests debian 10 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-14124/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14124/artifact/TOPO5U18AMD64/TopotestDetails/

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 6
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 0
  • Static analyzer (clang)
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 4
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7

@ton31337
Copy link
Member

ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 18, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-14206/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-14206/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5U18I386/TopotestDetails/

Topotests debian 10 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-14206/test

Topology Tests failed for Topotests debian 10 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14206/artifact/TOPO5DEB10AMD64/TopotestDetails/

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 1
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 7
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 0
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 9
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 7
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 1

@patrasar patrasar self-requested a review September 20, 2023 12:08
@riw777
Copy link
Member

riw777 commented Sep 26, 2023

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-14338/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5U18AMD64/TopotestDetails/

Topotests debian 10 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-14338/test

Topology Tests failed for Topotests debian 10 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-14338/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14338/artifact/TOPO5U18I386/TopotestDetails/

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 3
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 7
  • Static analyzer (clang)
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 2
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 7

@Jafaral Jafaral added this to the 9.1 milestone Oct 3, 2023
@Jafaral
Copy link
Member

Jafaral commented Oct 3, 2023

ci:rerun

@riw777
Copy link
Member

riw777 commented Oct 24, 2023

let's try this again ...
ci:rerun

@ton31337 ton31337 removed this from the 9.1 milestone Nov 7, 2023
@riw777
Copy link
Member

riw777 commented Dec 5, 2023

looks like the change is causing a ci failure:

$->routes->172.16.255.254/32: expected has the following element at index 0 which is not present in output: 
  
  	{
  	    "metric": 0
  	}
  
  	Closest match in output is at index 0 with the following errors: 
  
  	> $->routes->172.16.255.254/32[0]->metric: output has element with value '777' but in expected it has value '0'

Copy link

github-actions bot commented Jun 3, 2024

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

@riw777 riw777 removed the autoclose label Jun 4, 2024
@github-actions github-actions bot added the rebase PR needs rebase label Jun 4, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@riw777
Copy link
Member

riw777 commented Oct 22, 2024

keep open

Test is failing locally:
2023-09-06 18:39:56,865 DEBUG: r1: vtysh result:
        Hello, this is FRRouting (version 9.1-dev).
        Copyright 1996-2005 Kunihiro Ishiguro, et al.

        r1# conf t
        r1(config)# router ospf
        r1(config-router)# ospf router-id 1.1.1.1
        For this router-id change to take effect, use "clear ip ospf process" command
        r1(config-router)#
2023-09-06 18:39:56,865 DEBUG: root: GOT LINE: 'SUCCESS: 1.0.0.0'
2023-09-06 18:39:56,866 DEBUG: root: GOT LINE: '2023-09-06 18:39:55,982 INFO: TESTER: root: Waiting for 1.1.1.1'
2023-09-06 18:39:56,867 DEBUG: root: GOT LINE: '2023-09-06 18:39:55,982 DEBUG: TESTER: root: expected '1.1.1.1' != '1.0.0.0''
2023-09-06 18:39:56,867 DEBUG: root: GOT LINE: 'waiting on notify'

Sure looks like the router-id is not allowed to be changed because
neighbors have already been formed.  If we are changing the router-id
then let's clear the process to allow it to correctly change.

Signed-off-by: Donald Sharp <[email protected]>
The test is failing because on r2 we are looking for a metric of 777
on startup, but the start of looking for this happens to be after
the 5 second delay that is setup in the config.

On r1:

2023/09/06 17:05:14.999407 BGP: [G822R-SBMNH] config-from-file# router bgp 65001
2023/09/06 17:05:15.003060 BGP: [G822R-SBMNH] config-from-file#   bgp max-med on-startup 5 777
2023/09/06 17:05:15.003342 BGP: [G822R-SBMNH] config-from-file#   no bgp ebgp-requires-policy
2023/09/06 17:05:15.003453 BGP: [G822R-SBMNH] config-from-file#   neighbor 192.168.255.2 remote-as 65001
2023/09/06 17:05:15.004029 BGP: [G822R-SBMNH] config-from-file#   neighbor 192.168.255.2 timers 3 10
2023/09/06 17:05:15.004242 BGP: [G822R-SBMNH] config-from-file#   address-family ipv4 unicast
2023/09/06 17:05:15.004329 BGP: [G822R-SBMNH] config-from-file#     redistribute connected
2023/09/06 17:05:15.005023 BGP: [G822R-SBMNH] config-from-file#   exit-address-family
2023/09/06 17:05:15.005140 BGP: [G822R-SBMNH] config-from-file#   !
2023/09/06 17:05:15.005162 BGP: [G822R-SBMNH] config-from-file# !
2023/09/06 17:05:17.538112 BGP: [M7Q4P-46WDR] vty[25]@> enable
2023/09/06 17:05:17.546700 BGP: [M7Q4P-46WDR] vty[25]@# clear log cmdline-targets
2023/09/06 17:05:17.570635 BGP: [M7Q4P-46WDR] vty[25]@(config)# log commands
2023/09/06 17:05:17.572518 BGP: [M7Q4P-46WDR] vty[25]@(config)# log timestamp precision 6
2023/09/06 17:05:24.982647 BGP: [YNGC8-65JDM] Begin maxmed onstartup mode - timer 5 seconds
2023/09/06 17:05:26.033134 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.255.2 in vrf default
2023/09/06 17:05:29.982960 BGP: [N1747-51Y51] Max med on startup ended - timer expired.

on r2:

2023/09/06 17:05:23.976029 BGP: [G822R-SBMNH] config-from-file# !
2023/09/06 17:05:26.084086 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.255.1 in vrf default
2023/09/06 17:05:27.280103 BGP: [M7Q4P-46WDR] vty[25]@> enable
2023/09/06 17:05:27.290204 BGP: [M7Q4P-46WDR] vty[25]@# clear log cmdline-targets
2023/09/06 17:05:27.328798 BGP: [M7Q4P-46WDR] vty[25]@(config)# log commands
2023/09/06 17:05:27.335032 BGP: [M7Q4P-46WDR] vty[25]@(config)# log timestamp precision 6
2023/09/06 17:05:31.558216 BGP: [M7Q4P-46WDR] vty[5]@> enable
2023/09/06 17:05:31.562482 BGP: [M7Q4P-46WDR] vty[5]@# do show logging
2023/09/06 17:05:32.942204 BGP: [M7Q4P-46WDR] vty[5]@> enable
2023/09/06 17:05:32.946745 BGP: [M7Q4P-46WDR] vty[5]@# show ip bgp neighbor 192.168.255.1 json
2023/09/06 17:05:34.173879 BGP: [M7Q4P-46WDR] vty[5]@> enable
2023/09/06 17:05:34.178448 BGP: [M7Q4P-46WDR] vty[5]@# show ip bgp neighbor 192.168.255.1 routes json
2023/09/06 17:05:36.459365 BGP: [M7Q4P-46WDR] vty[5]@> enable
2023/09/06 17:05:36.472019 BGP: [M7Q4P-46WDR] vty[5]@# show ip bgp neighbor 192.168.255.1 routes json
2023/09/06 17:05:38.557840 BGP: [M7Q4P-46WDR] vty[5]@> enable
2023/09/06 17:05:38.558948 BGP: [M7Q4P-46WDR] vty[5]@# show ip bgp neighbor 192.168.255.1 routes json
2023/09/06 17:05:40.198563 BGP: [M7Q4P-46WDR] vty[5]@> enable

Notice that the 5 second delay for the max med expires at 29 seconds but the show routes
on r2 does not even begin until 34 seconds, long after the max med has expired and the
test has moved on.

Let's relax the max-med timer to 30 seconds and modify the test to wait a bit longer for
both finding it and expiring timer.

Signed-off-by: Donald Sharp <[email protected]>
@riw777 riw777 merged commit c84a680 into FRRouting:master Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix master rebase PR needs rebase size/XS tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants