lib,*: add vrf id to pbr rule results zapi message #14533
Conversation
zebra/zapi_msg.c
Outdated
| @@ -854,6 +854,7 @@ void zsend_rule_notify_owner(const struct zebra_dplane_ctx *ctx, | |||
| stream_putl(s, dplane_ctx_rule_get_seq(ctx)); | |||
| stream_putl(s, dplane_ctx_rule_get_priority(ctx)); | |||
| stream_putl(s, dplane_ctx_rule_get_unique(ctx)); | |||
| stream_putl(s, dplane_ctx_rule_get_vrfid(ctx)); | |||
There was a problem hiding this comment.
Doesn't this really belong in the zclient_create_header?
There was a problem hiding this comment.
I know there's a slot there, but I was concerned about whether someone would mis-interpret ... something, so I kept the new value in the rule-specific encoding?
There was a problem hiding this comment.
I think it should be about consistency. The vrf_id should be set properly in the header for the vrf we are talking about. We should be using VRF_DEFAULT there when the zapi command is VRF free. I have tried to follow this rule when doing the coding
There was a problem hiding this comment.
ok, makes sense: I'll push an update...
There was a problem hiding this comment.
I've pushed an update removing the zclient api change.
The iprule/pbr rule object has a vrf id, and zebra uses that internally, but the vrf id isn't returned to clients who install rules and are waiting for results. Include the vrf_id sent by the client in the zapi result notification message; update the existing clients so they decode the id. Signed-off-by: Mark Stapp <[email protected]>
mjstapp
force-pushed
the
fix_rule_notify_vrf
branch
from
efe8455 to
4fabe90
Compare
|
ci:rerun |
The iprule/pbr rule object has a vrf id, and zebra uses that internally, but the vrf id isn't returned to clients who install rules and are waiting for results. Include the vrf_id sent by the client in the zapi result notification message; update the existing clients so they decode the id.