Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zebra: add xxxCHAIN netlink messages to handler, ignore #14577

Merged
merged 1 commit into from
Oct 12, 2023
Merged

zebra: add xxxCHAIN netlink messages to handler, ignore #14577

merged 1 commit into from
Oct 12, 2023

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Oct 12, 2023 •
edited
Loading

Add the RTM_xxxCHAIN netlink message codes to the callback that may see them; this prevents zebra from logging errors about the unknown message types. We ignore these (for now).

Fixes: #14575

@frrbot frrbot bot added the zebra label Oct 12, 2023
@donaldsharp
Copy link
Member

This is not quite the way I would prefer to handle this. netlink_information_fetch should be modified to know about these two non-handled functions in the switch statement and the flog_err should be left alone imo. I want someone who is working on new netlink messages to see the unequivocal non-handling of the new netlink messages. In other words I want an informed programming choice being made by the developer.

zebra: add RTM_xxxCHAIN message codes, ignore
620daa3 
We may receive some xxxCHAIN netlink messages, but we ignore
them (currently). Add them to the basic handler callback so
that we don't log errors about them.

Signed-off-by: Mark Stapp <[email protected]>
@mjstapp mjstapp force-pushed the fix_zebra_nlmsg_unknown branch from 4c405be to 620daa3 Compare October 12, 2023 14:01
@github-actions github-actions bot added size/XS and removed size/S labels Oct 12, 2023
@mjstapp mjstapp changed the title zebra: remove error log for unknown netlink msg zebra: add xxxCHAIN netlink messages to handler, ignore Oct 12, 2023
@donaldsharp
Copy link
Member

thanks this is what I would do as well.

@Jafaral
Copy link
Member

Jafaral commented Oct 12, 2023

@Mergifyio backport dev/9.1

@mergify
Copy link

mergify bot commented Oct 12, 2023 •
edited
Loading

backport dev/9.1

✅ Backports have been created

@donaldsharp donaldsharp merged commit df03bf9 into FRRouting:master Oct 12, 2023
79 checks passed
@mergify mergify bot mentioned this pull request Oct 12, 2023
Merged
donaldsharp added a commit that referenced this pull request Oct 13, 2023
@donaldsharp
Merge pull request #14581 from FRRouting/mergify/bp/dev/9.1/pr-14577
2837ce0 
zebra: add xxxCHAIN netlink messages to handler, ignore (backport #14577)
@mjstapp mjstapp deleted the fix_zebra_nlmsg_unknown branch October 23, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
backport master size/XS zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown netlink nlmsg_type (100) vrf 0 FRR 9.0.1
4 participants
@mjstapp @donaldsharp @Jafaral @ton31337