Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: Remove static ARP entries on interface down events #14698

Conversation

ton31337
Copy link
Member

Without this patch, static ARP entries remain active even if the interface is down, but the kernel already removed them.

Closes #14652

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ton31337
Copy link
Member Author

ci:rerun AS stuck

@ton31337
Copy link
Member Author

@Mergifyio backport dev/9.1

Copy link

mergify bot commented Oct 31, 2023

backport dev/9.1

✅ Backports have been created

zebra/zebra_pbr.h Outdated Show resolved Hide resolved
zebra/redistribute.c Outdated Show resolved Hide resolved
@ton31337 ton31337 force-pushed the fix/remove_static_arp_entries_on_ifdown_events branch 2 times, most recently from 53140d1 to 490d220 Compare October 31, 2023 15:15
@ton31337 ton31337 requested a review from donaldsharp October 31, 2023 15:23
@ton31337 ton31337 force-pushed the fix/remove_static_arp_entries_on_ifdown_events branch from 490d220 to 6348c81 Compare October 31, 2023 15:30
@ton31337
Copy link
Member Author

ton31337 commented Nov 1, 2023

ci:rerun stuck CI

@ton31337
Copy link
Member Author

ton31337 commented Nov 2, 2023

ci:rerun related to FRRouting/netdef-ci-github-app#16

@ton31337 ton31337 force-pushed the fix/remove_static_arp_entries_on_ifdown_events branch from 6348c81 to 2798506 Compare November 2, 2023 21:01
@ton31337 ton31337 added this to the 9.1 milestone Nov 5, 2023
@davischw
Copy link
Contributor

davischw commented Nov 5, 2023

ci:rerun Address-sanitizer detected crash, but CI job hung because of disabled hang detection.

@davischw
Copy link
Contributor

davischw commented Nov 5, 2023

@ton31337 Address-Sanitizer seems to be detecting issues. Take a look at the logs of the recent CI build (https://ci1.netdef.org/browse/FRR-PULLREQ3-528)

Without this patch, static ARP entries remain active even if the interface is
down, but the kernel already removed them.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the fix/remove_static_arp_entries_on_ifdown_events branch from 2798506 to a35bb7e Compare November 6, 2023 13:01
@riw777 riw777 merged commit cf51579 into FRRouting:master Nov 7, 2023
79 checks passed
@ton31337 ton31337 deleted the fix/remove_static_arp_entries_on_ifdown_events branch November 7, 2023 16:15
ton31337 added a commit that referenced this pull request Nov 7, 2023
zebra: Remove static ARP entries on interface down events (backport #14698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRR: stale arp entries found in 'show ip neigh' vtysh command (with specific scenario)
4 participants