ospfd:fix show_ip_ospf_gr_helper #14710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teletajp
force-pushed
the
fix_show_ospf_gr_helper_cmd
branch
from
0f5068c to
0c8c95f
Compare
teletajp
force-pushed
the
fix_show_ospf_gr_helper_cmd
branch
from
0c8c95f to
1666237
Compare
|
ci:rerun |
|
@Mergifyio backport dev/9.1 |
❌ No backport have been created
GitHub error: |
|
Could you put a decent description in the commit message what is the actual fix here? |
teletajp
force-pushed
the
fix_show_ospf_gr_helper_cmd
branch
from
791ddd5 to
e9924fc
Compare
|
@teletajp please write a more detailed explanation (as in the PR's description) to the commit. With real outputs, it would be even better. |
Fix for the command "show ip ospf vrf NAME graceful-restart helper".
FRR did not show information by vrf's name.
If i have router ospf vrf red, vtysh's command
'show ip ospf vrf red graceful-restart helper' will not show anything.
But command 'show ip ospf vrf all graceful-restart helper' will work
normally. This fix fixes the display of information by vrf's name.
Example:
frr1# show ip ospf vrf vrf-1 graceful-restart helper
VRF Name: vrf-1
OSPF Router with ID (192.168.255.81)
Graceful restart helper support enabled.
Strict LSA check is enabled.
Helper supported for Planned and Unplanned Restarts.
Supported Graceful restart interval: 1800(in seconds).
Signed-off-by: teletajp <[email protected]>
teletajp
force-pushed
the
fix_show_ospf_gr_helper_cmd
branch
from
e9924fc to
62754e1
Compare
I added a description to the commit |
|
@Mergifyio backport stable/9.1 |
✅ Backports have been created
|
donaldsharp
added a commit
that referenced
this pull request
Nov 21, 2023
ospfd:fix show_ip_ospf_gr_helper (backport #14710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for the command "show ip ospf vrf NAME graceful-restart helper detail". FRR did not show information by vrf's name.
Error description: If i have
router ospf vrf red, vtysh's commandshow ip ospf vrf red graceful-restart helperwill not show anything. But commandshow ip ospf vrf all graceful-restart helperwill work normally. This fix fixes the display of information by vrf's name.