Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Check received prefixes before immediately sending dynamic capabilities #14756

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Nov 8, 2023

No description provided.

…abilities

If we send capabilities immediately, before receiving an UPDATE message, we end up
with a notification received from the neighbor. Let's wait until we have the fully
converged topology and do the stuff.

Tested locally and can't replicate the failure, let's see how happy is the CI this time.

Signed-off-by: Donatas Abraitis <[email protected]>
@frrbot frrbot bot added the tests Topotests, make check, etc label Nov 8, 2023
@ton31337
Copy link
Member Author

ton31337 commented Nov 8, 2023

@Mergifyio backport dev/9.1

Copy link

mergify bot commented Nov 8, 2023

backport dev/9.1

✅ Backports have been created

@ton31337 ton31337 added this to the 9.1 milestone Nov 8, 2023
@donaldsharp donaldsharp merged commit 314a98d into FRRouting:master Nov 9, 2023
80 checks passed
@ton31337 ton31337 deleted the fix/bgpd_dynamic_cap_addpath_topotest branch November 9, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport master size/M tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants