tests: multiple OSPF routers connected to a single switch #14775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianomarto
force-pushed
the
test_ospfd_single_switch2
branch
3 times, most recently
from
4931b54 to
f69d3a4
Compare
adrianomarto
force-pushed
the
test_ospfd_single_switch2
branch
2 times, most recently
from
e1777ba to
6511d20
Compare
ton31337
approved these changes
Nov 16, 2023
|
ci:rerun |
|
Can we get this looked at-- Looks like a change is needed in the new test? |
|
@adrianomarto still working on this? |
|
The JSONDecodeError is expected to happen on older operating systems, such as Ubuntu 18.04. That is because they don't support the "-j" option in the "ip -j route". @ton31337 agreed this would not be a problem as those operating systems would be deprecated soon. @riw777, which platform has produced this result? |
adrianomarto
force-pushed
the
test_ospfd_single_switch2
branch
2 times, most recently
from
3b12cf8 to
d9785fd
Compare
A large set of routers are connected to the same switch. Each router shares a single network. All shared networks must be reachable from all routers. Signed-off-by: "Adriano Marto Reis" <[email protected]>
adrianomarto
force-pushed
the
test_ospfd_single_switch2
branch
from
d9785fd to
f3de123
Compare
|
I modified the test so it is only executed if the target platform supports the command "ip -j route get". |
|
Waiting on @donaldsharp for a bit before pushing this ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large set of routers are connected to the same switch. Each router shares a single network. All shared networks must be reachable from all routers.