Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuring ipv6 ospf6 cost on loopback interface does not work #14777

Closed
pguibert6WIND opened this issue Nov 13, 2023 · 5 comments · Fixed by #14787
Closed

configuring ipv6 ospf6 cost on loopback interface does not work #14777

pguibert6WIND opened this issue Nov 13, 2023 · 5 comments · Fixed by #14787

Comments

@pguibert6WIND
Copy link
Member

FRR upstream
ubuntu-22.04

Describe the bug

Configuring ipv6 cost over loopback interface is useless.
The value seems to be reset when pursuing the configuration.

To Reproduce

ubuntu2204(config)# interface lo
ubuntu2204(config-if)# ipv6 ospf6 cost 44
ubuntu2204(config-if)# do show running-config
Building configuration...

Current configuration:
!
frr version 9.2-dev-my-manual-build
frr defaults traditional
hostname ubuntu2204
log stdout
no ip forwarding
no ipv6 forwarding
!
interface lo
ipv6 ospf6 cost 44
exit
!
end
ubuntu2204(config-if)# ipv6 ospf6 network point-to-point
2023/11/13 12:18:25 OSPF6: [RB0PM-VM0Y3] interface_up: Not scheduling Hello for lo as there is no area assigned yet
ubuntu2204(config-if)# do show running-config
Building configuration...

Current configuration:
!
frr version 9.2-dev-my-manual-build
frr defaults traditional
hostname ubuntu2204
log stdout
no ip forwarding
no ipv6 forwarding
!
interface lo
ipv6 ospf6 cost 0
ipv6 ospf6 network point-to-point
exit

Expected behavior

The ospf6 cost 44 is kept.

Additional context
("80dfa9e012eb") - ospf6d: Set loopback interface cost to 0

breaks that behaviour

@pguibert6WIND pguibert6WIND added the triage Needs further investigation label Nov 13, 2023
@ton31337 ton31337 self-assigned this Nov 13, 2023
@ton31337 ton31337 added ospfv3 bug and removed ospfv3 triage Needs further investigation labels Nov 13, 2023
@ton31337
Copy link
Member

@pguibert6WIND just a question: does it make sense to set network type to point-to-point for the loopback interface?

@ton31337 ton31337 added the triage Needs further investigation label Nov 13, 2023
@pguibert6WIND
Copy link
Member Author

@pguibert6WIND just a question: does it make sense to set network type to point-to-point for the loopback interface?

I am not an ospf6 specialist. Personally, I think it does not make sense. I just want to point out the fact that there are multiple places in the code where the ospf cost is overridden (mostly when interface_up() is called).

About last patch (Set loopback interface cost to 0) , I wonder if it was not better to increase the range by 0 for loopback interfaces only ?

@ton31337
Copy link
Member

I'd say, we shouldn't allow changing network type for a loopback interface at all, but might be wrong. Maybe @aceelindem or @choppsv1 could advice here?

@pguibert6WIND
Copy link
Member Author

I'd say, we shouldn't allow changing network type for a loopback interface at all, but might be wrong. Maybe @aceelindem or @choppsv1 could advice here?

network-type change is not the problem.
If you just turn down the lo interface, you will even lose the cost configuration.

There is a problem with keeping the cost per interface configuration !

@ton31337 ton31337 removed the triage Needs further investigation label Nov 13, 2023
@ton31337
Copy link
Member

A fixup here #14787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants