vtysh: clean vtysh_file_locked when exiting config node #14813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag should be cleared to make sure it's not reused the next time we enter the config node. Signed-off-by: Igor Ryzhov <[email protected]>
|
@Mergifyio backport stable/9.1 |
✅ Backports have been created
|
donaldsharp
reviewed
Nov 20, 2023
| @@ -2396,14 +2397,18 @@ static int vtysh_exit(struct vty *vty) | |||
| vty->node = cnode->parent_node; | |||
|
|
|||
| if (vty->node == CONFIG_NODE) { | |||
| bool locked = vty->vtysh_file_locked; | |||
There was a problem hiding this comment.
What's the point of adding a bool here? Why isn't the if (vty->vtysh_file_locked) sufficient?
There was a problem hiding this comment.
vty->vtysh_file_locked will be overwritten by vtysh_execute("end") on the next line. We need to remember it.
donaldsharp
added a commit
that referenced
this pull request
Nov 21, 2023
vtysh: clean vtysh_file_locked when exiting config node (backport #14813)
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag should be cleared to make sure it's not reused the next time we enter the config node.