-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redhat: Set config/logfile mask to be 0640 for RHEL #14821
redhat: Set config/logfile mask to be 0640 for RHEL #14821
Conversation
Debian-based OSs have this by default. Signed-off-by: Donatas Abraitis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really fix the problem… it just makes it so it works for anyone who needs 0640 like in #14817 — and what happens to people who are relying on it being 0600 for security reasons?
I thought the problem was that the issue opener wanted 640 but frr was writing 600 because frr was compiled to use 600. If the end operator wants something else I think that it should be on the end operator to recompile with different options |
Yes, but why do we keep different behaviors for Debian/RHEL packages? Debian has 0640, RHEL - 0600. |
Have you looked into the git history to see if there is a logical explanation? More than likely there were 2 different people who built the packaging and as such we got slightly different behavior. All in all, if we are going to change something I would prefer that debian go more restrictive. I will demur to @eqvinox 's opinion here though if he doesn't want to change anything |
Yes, Debian has 0640 from the very beginning (most likely from the Quagga times): 4d91638 RHEL had 0600 from the very beginning too. Nobody touched that. |
We even provide the documentation for source compilation for Debian, *BSD, snapcrafts to use 0640, but RHEL is somehow so special here :) |
Related: #14817