Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redhat: Set config/logfile mask to be 0640 for RHEL #14821

Conversation

ton31337
Copy link
Member

Related: #14817

Debian-based OSs have this by default.

Signed-off-by: Donatas Abraitis <[email protected]>
Copy link
Contributor

@eqvinox eqvinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really fix the problem… it just makes it so it works for anyone who needs 0640 like in #14817 — and what happens to people who are relying on it being 0600 for security reasons?

@ton31337 ton31337 closed this Nov 17, 2023
@ton31337 ton31337 deleted the fix/set_mask_for_config_logfile branch November 17, 2023 17:48
@ton31337 ton31337 restored the fix/set_mask_for_config_logfile branch November 21, 2023 06:53
@ton31337 ton31337 reopened this Nov 21, 2023
@donaldsharp
Copy link
Member

I thought the problem was that the issue opener wanted 640 but frr was writing 600 because frr was compiled to use 600. If the end operator wants something else I think that it should be on the end operator to recompile with different options

@ton31337
Copy link
Member Author

Yes, but why do we keep different behaviors for Debian/RHEL packages? Debian has 0640, RHEL - 0600.

@donaldsharp
Copy link
Member

Have you looked into the git history to see if there is a logical explanation? More than likely there were 2 different people who built the packaging and as such we got slightly different behavior. All in all, if we are going to change something I would prefer that debian go more restrictive. I will demur to @eqvinox 's opinion here though if he doesn't want to change anything

@ton31337
Copy link
Member Author

Have you looked into the git history to see if there is a logical explanation?

Yes, Debian has 0640 from the very beginning (most likely from the Quagga times): 4d91638

RHEL had 0600 from the very beginning too. Nobody touched that.

@ton31337
Copy link
Member Author

We even provide the documentation for source compilation for Debian, *BSD, snapcrafts to use 0640, but RHEL is somehow so special here :)

@ton31337 ton31337 closed this Dec 5, 2023
@ton31337 ton31337 deleted the fix/set_mask_for_config_logfile branch December 5, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants