various nexthop group fixes #14885
Merged
various nexthop group fixes #14885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:rerun |
ton31337
reviewed
Nov 28, 2023
zebra/zserv.h
Outdated
| @@ -185,6 +185,9 @@ struct zserv { | |||
| uint32_t local_es_evi_add_cnt; | |||
| uint32_t local_es_evi_del_cnt; | |||
| uint32_t error_cnt; | |||
| uint32_t l3nhg_add_cnt; | |||
There was a problem hiding this comment.
Can it be L2 nhg at all? Asking because what role does the L3 prefix play here.
There was a problem hiding this comment.
It can be but I believe we are quibling a bit. I wouldn't worry about this at all.
There was a problem hiding this comment.
Can it be L2 nhg at all? Asking because what role does the L3 prefix play here.
mmm . actually a nexthop is a nexthop group made up of IP nexthops
I just try to stick with what the system offers.
unless you explain me what is a L2 nexthop..
There was a problem hiding this comment.
it's a nexthop for type 1 evpn routes in the multihoming scenario. This api that you are adding here handles this for both l2 nexthops as well as l3 nexthops. I know this because I was involved in writing this code w/ Anuradha
There was a problem hiding this comment.
It can be but I believe we are quibling a bit. I wouldn't worry about this at all.
Not sure I understood the comment correctly :) Does it mean we should keep l3nhg_* or use nhg_*?
There was a problem hiding this comment.
updated with nhg_* as everyone can understand it as desired
When removing the last nexthop from a nexthop-group, the nexthop group remains in the zebra contexts: > ubuntu2204(config)# nexthop-group gdgd > 2023/11/23 14:06:36 SHARP: [Q5NBA-GN1BG] NHG ID assigned: 179687502 > ubuntu2204(config-nh-group)# nexthop 192.0.2.7 loop1 > ubuntu2204(config-nh-group)# 2023/11/23 14:06:38 ZEBRA: [VNMVB-91G3G] _netlink_nexthop_build_group: ID (179687502): group 338 > 2023/11/23 14:06:38 ZEBRA: [R43C6-KYHWT] netlink_nexthop_msg_encode: RTM_NEWNEXTHOP, id=179687502 > 2023/11/23 14:06:38 ZEBRA: [HYEHE-CQZ9G] nl_batch_send: netlink-dp (NS 0), batch size=44, msg cnt=1 > 2023/11/23 14:06:38 SHARP: [JWRCN-N9K90] Installed nhg 179687502 > > ubuntu2204(config-nh-group)# no nexthop 192.0.2.7 loop1 > 2023/11/23 14:06:47 SHARP: [Y2G2F-ZTW6M] nhg_add: nhg 179687502 not sent: no valid nexthops > ubuntu2204(config-nh-group)# do show nexthop-group rib 179687502 > ID: 179687502 (sharp) > RefCnt: 1 > Uptime: 00:00:23 > VRF: default > Valid, Installed > Depends: (338) > via 192.0.2.7, loop1 (vrf default), weight 1 Fix this by sending an NHG_DEL message when no nexthops are attached, and when the id was already installed. Fixes: 5a9c093 ("sharpd: don't send invalid nexthop-groups to zebra") Signed-off-by: Philippe Guibert <[email protected]>
Display a specific log message when the rt_nhe parameter is not set at all. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
misc_nhg_fixes
branch
from
a4dfa3d to
dd15b0a
Compare
Add three counters that account for the nhg operations that are using the zebra API with the NHG_ADD and NHG_DEL commands. > # show zebra client > [..] > Type Add Update Del > ================================================== > IPv4 100 0 0 > IPv6 0 0 0 > Redist:v4 0 0 0 > Redist:v6 0 0 0 > NHG 1 1 1 > VRF 3 0 0 > [..] Signed-off-by: Philippe Guibert <[email protected]>
When allocating big protocol level identifiers, the number range is big, and when pushing to netlink messages, the first nexthop group is truncated, whereas the nexthop has been installed on the kernel. > ubuntu2204(config)# nexthop-group A > ubuntu2204(config-nh-group)# group 1 > ubuntu2204(config-nh-group)# group 2 > ubuntu2204(config-nh-group)# exi > ubuntu2204(config)# nexthop-group 1 > ubuntu2204(config-nh-group)# nexthop 192.0.2.130 loop1 enable-proto-nhg-control > ubuntu2204(config-nh-group)# exi > ubuntu2204(config)# nexthop-group 2 > ubuntu2204(config-nh-group)# nexthop 192.0.2.131 loop1 enable-proto-nhg-control > [..] > 2023/11/24 16:47:40 ZEBRA: [VNMVB-91G3G] _netlink_nexthop_build_group: ID (179687500): group 17968/179687502 > # ip nexthop ls > id 179687500 group 179687501/179687502 proto 194 Fix this by increasing the buffer size when appending the first number. Fixes: 8d03bc5 ("zebra: Handle nhg_hash_entry encaps/more debugging") Signed-off-by: Philippe Guibert <[email protected]>
The nexthop_group_active_nexthop_num_no_recurse() function is no more used. Let us remove the function call. Fixes: 148813c ("zebra: zebra_nhg check each nexthop for active, not just number") Signed-off-by: Philippe Guibert <[email protected]>
When stopping a VRF, the linked list entries must be removed too. Fixes: 98cbbae ("lib: Handle if up/down and vrf enable/disable events") Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
misc_nhg_fixes
branch
from
dd15b0a to
0c34fa2
Compare
|
ci:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various tiny fixes about nexthop group handling.