-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: add multiple paths support for draft ietf bgp4v2 in nlriTable #14889
Conversation
d91c4e9
to
6fe1c69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
ci:rerun |
6fe1c69
to
e0a1d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also styling warning:
warning: 1 line adds whitespace errors.
Report for bgp_snmp_bgp4v2.c | 2 issues
< ERROR: trailing whitespace
< 717: FILE: /tmp/f1-31970/bgp_snmp_bgp4v2.c:717:
Test nor working with ARM CPU. need to change the test paradigm. |
e0a1d0f
to
c8633c3
Compare
c8633c3
to
a5272f9
Compare
There is no support for dumping multiple paths for the same prefix. The current implementation only takes the first available entry. Fix this by walking over the list of available paths, ordered by peer. The nlri index is set gradually for each path. Signed-off-by: Francois Dumontet <[email protected]>
a5272f9
to
b432c8f
Compare
ci:rerun not all checks started up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cd32b14
to
797dc3f
Compare
multi path support by snmp implies change in configuration and expected tests results. ipv6 trap test output is now ordered to avoid radom result due to timeline. Signed-off-by: Francois Dumontet <[email protected]> Signed-off-by: Philippe Guibert <[email protected]>
797dc3f
to
869047f
Compare
ci:rerun |
ci:rerun failure not related to pull request |
There is no support for dumping multiple paths for the same prefix.
The current implementation only takes the first available entry.
Fix this by walking over the list of available paths, ordered by peer.
The nlri index is set gradually for each path.