staticd: fix changing to source auto in bfd monitor #14922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Dec 1, 2023
staticd/static_routes.c
Outdated
| case STATIC_IPV4_GATEWAY_IFNAME: | ||
| case STATIC_IPV6_GATEWAY_IFNAME: | ||
| static_zebra_nht_register(nh, false); |
There was a problem hiding this comment.
Isn't possible to do this operation only if the source IP is different from the previous one (last used)?
There was a problem hiding this comment.
You are correct. It is possible.
Done
When monitoring a static route with BFD multi-hop, the source IP can be either configured or retrieved from NextHop-Tracking (NHT). After removing a configured source, the source is supposed to be retrieved from NHT but it remains to the previous value. This is problematic if the user desires to fix the configuration of a incorrect source IP. For example, theses two commands results in the incorrect state: > ip route 10.0.0.0/24 10.1.0.1 bfd multi-hop source 10.2.2.2 > ip route 10.0.0.0/24 10.1.0.1 bfd multi-hop When removing the source, BFD is unable to find the source from NHT via bfd_nht_update() were called. Force zebra to resend the information to BFD by unregistering and registering again NHT. The (...)/frr-nexthops/nexthop northbound apply_finish function will trigger a call to static_install_nexthop() that does a call to static_zebra_nht_register(nh, true); Fixes: b7ca809 ("lib: BFD automatic source selection") Signed-off-by: Louis Scalbert <[email protected]>
Redispatch tests in bfd_topo3 in order to prepare next commit. Cosmetic change. Signed-off-by: Louis Scalbert <[email protected]>
Test setting a wrong bfd source and restore the source auto parameter. Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-bfd-static-source
branch
from
a74d734 to
94640da
Compare
rzalamena
approved these changes
Dec 6, 2023
|
https://github.com/Mergifyio backport stable/9.1 |
✅ Backports have been created
|
|
https://github.com/Mergifyio backport stable/9.0 |
✅ Backports have been created
|
This was referenced Dec 6, 2023
ton31337
added a commit
that referenced
this pull request
Dec 6, 2023
staticd: fix changing to source auto in bfd monitor (backport #14922)
donaldsharp
added a commit
that referenced
this pull request
Dec 7, 2023
staticd: fix changing to source auto in bfd monitor (backport #14922)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When monitoring a static route with BFD multi-hop, the source IP can be
either configured or retrieved from NextHop-Tracking (NHT). After
removing a configured source, the source is supposed to be retrieved
from NHT but it remains to the previous value. This is problematic if
the user configured an incorrect source IP.
For example, theses two commands results in the incorrect state:
Unregister to nht before registering again on a route change. It forces
zebra to send again a ZEBRA_NEXTHOP_UPDATE zapi mesage to staticd in
order to trigger bfd_nht_update().
Fixes: b7ca809 ("lib: BFD automatic source selection")
Signed-off-by: Louis Scalbert [email protected]