Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpki: can not load config via frr-reload when retry_interval and expire_interval is present #15299

Closed
1 of 2 tasks
c-po opened this issue Feb 4, 2024 · 2 comments
Closed
1 of 2 tasks

rpki: can not load config via frr-reload when retry_interval and expire_interval is present #15299

c-po opened this issue Feb 4, 2024 · 2 comments
Assignees
@louis-6wind
Labels
triage Needs further investigation

Comments

@c-po
Copy link
Contributor

c-po commented Feb 4, 2024

Describe the bug

  • Did you check if this is a duplicate issue?
  • Did you test it on the latest FRRouting/frr master branch?

When using frr-reload.py for RPKI with the following two prameters inside the config, frr-reload.py will fail

 rpki retry_interval 600
 rpki expire_interval 7200

To Reproduce

rpki.txt

!
rpki
 rpki polling_period 300
 rpki retry_interval 600
 rpki expire_interval 7200
 rpki cache 1.2.3.4 3328 preference 10
exit
!

no-rpki.txt

!
rpki
exit
!

Running sudo /usr/lib/frr/frr-reload.py --reload --daemon bgpd --debug --stdout rpki.txt will fail

Expected behavior

Configuration should be applied, and vtysh -c "show run" should reveal the new config

!
rpki
 rpki polling_period 300
 rpki retry_interval 600
 rpki expire_interval 7200
 rpki cache 1.2.3.4 3328 preference 10
exit
!

Screenshots

[email protected]:~$ sudo /usr/lib/frr/frr-reload.py --reload --daemon bgpd --debug --stdout rpki.txt
2024-02-04 11:11:08,590  INFO: Called via "Namespace(input=None, reload=True, test=False, debug=True, log_level='info', stdout=True, pathspace=None, filename='rpki.txt', overwrite=False, bindir='/usr/bin', confdir='/etc/frr', rundir='/var/run/frr', vty_socket=None, daemon='bgpd', test_reset=False)"
2024-02-04 11:11:08,590  INFO: Loading Config object from file rpki.txt
2024-02-04 11:11:08,624 DEBUG: LINE rpki                                              : enter context ['rpki']
2024-02-04 11:11:08,625 DEBUG: LINE rpki polling_period 300                           : add to current context ['rpki']                                      
2024-02-04 11:11:08,625 DEBUG: LINE rpki retry_interval 600                           : add to current context ['rpki']                                      
2024-02-04 11:11:08,625 DEBUG: LINE rpki expire_interval 7200                         : add to current context ['rpki']                                      
2024-02-04 11:11:08,625 DEBUG: LINE rpki cache 1.2.3.4 3328 preference 10             : add to current context ['rpki']                                      
2024-02-04 11:11:08,625 DEBUG: LINE exit                                              : exit context ['rpki']
2024-02-04 11:11:08,664 DEBUG: New Frr Config
!
rpki
rpki polling_period 300
rpki retry_interval 600
rpki expire_interval 7200
rpki cache 1.2.3.4 3328 preference 10
exit
!

end

2024-02-04 11:11:08,664  INFO: Loading Config object from vtysh show running
2024-02-04 11:11:08,703 DEBUG: LINE frr version 9.0.2                                 : single-line context
2024-02-04 11:11:08,704 DEBUG: LINE frr defaults traditional                          : single-line context
2024-02-04 11:11:08,704 DEBUG: LINE hostname LR1.wue3                                 : single-line context
2024-02-04 11:11:08,704 DEBUG: LINE service integrated-vtysh-config                   : single-line context
2024-02-04 11:11:08,704 DEBUG: LINE rpki                                              : enter context ['rpki']
2024-02-04 11:11:08,704 DEBUG: LINE rpki polling_period 300                           : add to current context ['rpki']                                      
2024-02-04 11:11:08,704 DEBUG: LINE rpki cache 1.2.3.4 3328 preference 10             : add to current context ['rpki']                                      
2024-02-04 11:11:08,704 DEBUG: LINE exit                                              : exit context ['rpki']
2024-02-04 11:11:08,704 DEBUG: Running Frr Config (Pass #0)
frr version 9.0.2
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
rpki
rpki polling_period 300
rpki cache 1.2.3.4 3328 preference 10
exit
!
end
2024-02-04 11:11:08,705  INFO: "frr version 9.0.2" cannot be removed
2024-02-04 11:11:08,705  INFO: "frr defaults traditional" cannot be removed
2024-02-04 11:11:08,705  INFO: "service integrated-vtysh-config" cannot be removed
2024-02-04 11:11:08,745  INFO: Executed "no hostname LR1.wue3"
2024-02-04 11:11:08,745  INFO: /var/run/frr/reload-X8F6PA.txt content
['rpki\n rpki retry_interval 600\n', 'rpki\n rpki expire_interval 7200\n']
[4956|mgmtd] sending configuration
[4957|zebra] sending configuration
[4959|ripngd] sending configuration
[4958|ripd] sending configuration
[4960|ospfd] sending configuration
line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

[4958|ripd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4961|ospf6d] sending configuration
line 4: % Command incomplete[85]: rpki

[4959|ripngd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4956|mgmtd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4963|bgpd] sending configuration
[4957|zebra] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4964|isisd] sending configuration
[4962|ldpd] sending configuration
[4960|ospfd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

[4968|babeld] sending configuration
[4961|ospf6d] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

[4963|bgpd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

[4964|isisd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

[4971|watchfrr] sending configuration
[4973|staticd] sending configuration
[4974|bfdd] sending configuration
Waiting for children to finish applying config...
[4977|pim6d] sending configuration
[4962|ldpd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4968|babeld] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

[4974|bfdd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4971|watchfrr] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4977|pim6d] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4973|staticd] Configuration file[/etc/frr/frr.conf] processing failure: 4
2024-02-04 11:11:08,798 WARNING: frr-reload.py failed due to
vtysh (exec file) exited with status 4
2024-02-04 11:11:08,798  INFO: Loading Config object from vtysh show running
2024-02-04 11:11:08,836 DEBUG: LINE frr version 9.0.2                                 : single-line context
2024-02-04 11:11:08,837 DEBUG: LINE frr defaults traditional                          : single-line context
2024-02-04 11:11:08,837 DEBUG: LINE hostname LR1.wue3                                 : single-line context
2024-02-04 11:11:08,837 DEBUG: LINE service integrated-vtysh-config                   : single-line context
2024-02-04 11:11:08,837 DEBUG: LINE rpki                                              : enter context ['rpki']
2024-02-04 11:11:08,837 DEBUG: LINE rpki polling_period 300                           : add to current context ['rpki']                                      
2024-02-04 11:11:08,837 DEBUG: LINE rpki cache 1.2.3.4 3328 preference 10             : add to current context ['rpki']                                      
2024-02-04 11:11:08,837 DEBUG: LINE exit                                              : exit context ['rpki']
2024-02-04 11:11:08,837 DEBUG: Running Frr Config (Pass #1)
frr version 9.0.2
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
rpki
rpki polling_period 300
rpki cache 1.2.3.4 3328 preference 10
exit
!
end
2024-02-04 11:11:08,837  INFO: "frr version 9.0.2" cannot be removed
2024-02-04 11:11:08,837  INFO: "frr defaults traditional" cannot be removed
2024-02-04 11:11:08,837  INFO: "service integrated-vtysh-config" cannot be removed
2024-02-04 11:11:08,837  INFO: /var/run/frr/reload-4IV0MY.txt content
['rpki\n rpki retry_interval 600\n',
 'rpki\n rpki expire_interval 7200\n',
 'rpki\n rpki retry_interval 600\n',
 'rpki\n rpki expire_interval 7200\n']
[4981|mgmtd] sending configuration
[4983|ripd] sending configuration
[4982|zebra] sending configuration
[4984|ripngd] sending configuration
line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4985|ospfd] sending configuration
line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4986|ospf6d] sending configuration
[4982|zebra] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4981|mgmtd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4987|ldpd] sending configuration
[4988|bgpd] sending configuration
[4983|ripd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4989|isisd] sending configuration
line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4984|ripngd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4985|ospfd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4993|babeld] sending configuration
[4989|isisd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

[4986|ospf6d] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4987|ldpd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4996|watchfrr] sending configuration
[4999|bfdd] sending configuration
[4998|staticd] sending configuration
[4988|bgpd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4993|babeld] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 4: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

line 4: % Command incomplete[85]: rpki

[4998|staticd] Configuration file[/etc/frr/frr.conf] processing failure: 4
line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[4999|bfdd] Configuration file[/etc/frr/frr.conf] processing failure: 4
[4996|watchfrr] Configuration file[/etc/frr/frr.conf] processing failure: 4
Waiting for children to finish applying config...
[5002|pim6d] sending configuration
line 4: % Command incomplete[85]: rpki

line 7: % Command incomplete[85]: rpki

line 10: % Command incomplete[85]: rpki

[5002|pim6d] Configuration file[/etc/frr/frr.conf] processing failure: 4
2024-02-04 11:11:08,889 WARNING: frr-reload.py failed due to
vtysh (exec file) exited with status 4

Versions

  • OS Version: Debian 12 / VyOS 1.4
  • Kernel: 6.6.15
  • FRR Version: stable/9.0

Additional context
@c-po c-po added the triage Needs further investigation label Feb 4, 2024
@louis-6wind louis-6wind self-assigned this Feb 6, 2024
@louis-6wind
Copy link
Contributor

@c-po could you do the same test on the master branch ?

@c-po
Copy link
Contributor Author

c-po commented Feb 7, 2024

Issue does not persost on master.

I will create a frr-reload backport for stable/9.0

This was referenced Feb 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-6wind louis-6wind

Labels
triage Needs further investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ton31337 @c-po @louis-6wind