bgpd: update route leak after vrf interface changes #15351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:rerun |
ton31337
reviewed
Feb 14, 2024
| r1 = tgen.gears["r1"] | ||
|
|
||
| logger.info("Ping from default to DONNA") | ||
| output = r1.run("ping -c 4 -w 4 -I 10.0.4.1 10.0.0.1") |
Test functions were duplicated by mistakes. They were identical. Fixes: 8af61c8 ("topotests: test leak from the default vrf") Signed-off-by: Louis Scalbert <[email protected]>
Allow specifying a source_addr in check_ping library function. Signed-off-by: Louis Scalbert <[email protected]>
Use check_ping in bgp_vrf_route_leak_basic Signed-off-by: Louis Scalbert <[email protected]>
Locally leaked routes remain active after the nexthop VRF interface goes down. Update route leaking when the loopback or a VRF interface state change is received from zebra. Signed-off-by: Louis Scalbert <[email protected]>
Check that local route leaks are set to "inactive" when the VRF interface is shutdown and, conversely, that they are set to "active" when the VRF interface is unshut. Signed-off-by: Louis Scalbert <[email protected]>
If the VRF is not yet created and a BGP instance is created for the VRF, dependent leaked routes are inactive, which is normal. However, when the VRF interface appears, they remains inactive. Update route leak when a VRF interface appears. Note that routes to a deleted VRF are already removed by zebra. Signed-off-by: Louis Scalbert <[email protected]>
Ensure that a locally leaked route is updated after a VRF (dis)appears. Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-leak-vrf-interface
branch
from
cebb290 to
1262ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally leaked routes are not updated after the nexthop VRF interface appears/disappears or goes down/up.
Fix the issues