-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pimd: Fix PIM MLAG Update Peer Zebra Status Upon Local MLAG Connectio… #15918
Draft
routingrocks
wants to merge
1
commit into
FRRouting:master
Choose a base branch
from
routingrocks:rvaratharaj/pim_mlag_state_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
pimd: Fix PIM MLAG Update Peer Zebra Status Upon Local MLAG Connectio… #15918
routingrocks
wants to merge
1
commit into
FRRouting:master
from
routingrocks:rvaratharaj/pim_mlag_state_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routingrocks
force-pushed
the
rvaratharaj/pim_mlag_state_fix
branch
from
May 3, 2024 23:44
2e85117
to
b45ff52
Compare
ton31337
requested changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also styling from frrbot.
routingrocks
force-pushed
the
rvaratharaj/pim_mlag_state_fix
branch
from
July 29, 2024 22:37
15dd631
to
dd5abf7
Compare
…n Restoration Issue: In scenarios where the local MLAG connection is down, we currently halt processing peer MLAG messages. However, upon restoration of the local connection, we fail to update the peer Zebra status accordingly. Consider the case where the peer is up and sends FRR status messages to the local node. If CLAGd restarts on the local node while FRR is running, the local CLAGd assumes the peer is still down even when it's up. Fix: Update the peer Zebra status once the local MLAG connection is restored Testing: UT Ticket: # Signed-off-by: Rajesh Varatharaj <[email protected]>
routingrocks
force-pushed
the
rvaratharaj/pim_mlag_state_fix
branch
from
July 29, 2024 22:43
dd5abf7
to
2eeafae
Compare
CI_RUN |
ci:rerun |
@routingrocks are you going to continue with this? |
I need to work on this, got fully occupied with the current tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n Restoration
Issue:
In scenarios where the local MLAG connection is down, we currently halt processing peer MLAG messages. However, upon restoration of the local connection,
we fail to update the peer Zebra status accordingly.
Consider the case where the peer is up and sends FRR status messages to the local node. If CLAGd restarts on the local node while FRR is running, the local CLAGd assumes the peer is still down even when it's up.
Fix:
Update the peer Zebra status once the local MLAG connection is restored
Testing: UT
Ticket: #
Signed-off-by: Rajesh Varatharaj [email protected]