Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pimd: Fix PIM MLAG Update Peer Zebra Status Upon Local MLAG Connectio… #15918

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

routingrocks
Copy link
Contributor

…n Restoration

Issue:
In scenarios where the local MLAG connection is down, we currently halt processing peer MLAG messages. However, upon restoration of the local connection,
we fail to update the peer Zebra status accordingly.

Consider the case where the peer is up and sends FRR status messages to the local node. If CLAGd restarts on the local node while FRR is running, the local CLAGd assumes the peer is still down even when it's up.

Fix:
Update the peer Zebra status once the local MLAG connection is restored

Testing: UT

Ticket: #

Signed-off-by: Rajesh Varatharaj [email protected]

@frrbot frrbot bot added the pim label May 3, 2024
@routingrocks routingrocks marked this pull request as draft May 3, 2024 20:56
@routingrocks routingrocks force-pushed the rvaratharaj/pim_mlag_state_fix branch from 2e85117 to b45ff52 Compare May 3, 2024 23:44
@github-actions github-actions bot added size/M and removed size/S labels May 3, 2024
@routingrocks routingrocks marked this pull request as ready for review May 3, 2024 23:46
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also styling from frrbot.

pimd/pim_mlag.c Outdated Show resolved Hide resolved
pimd/pim_mlag.c Outdated Show resolved Hide resolved
pimd/pim_mlag.c Outdated Show resolved Hide resolved
pimd/pim_mlag.c Outdated Show resolved Hide resolved
pimd/pim_mlag.c Outdated Show resolved Hide resolved
pimd/pim_mlag.c Show resolved Hide resolved
@routingrocks routingrocks force-pushed the rvaratharaj/pim_mlag_state_fix branch from 15dd631 to dd5abf7 Compare July 29, 2024 22:37
…n Restoration

Issue:
In scenarios where the local MLAG connection is down, we currently halt processing
peer MLAG messages. However, upon restoration of the local connection,
 we fail to update the peer Zebra status accordingly.

Consider the case where the peer is up and sends FRR status messages to the local node.
If CLAGd restarts on the local node while FRR is running,
the local CLAGd assumes the peer is still down even when it's up.

Fix:
Update the peer Zebra status once the local MLAG connection is restored

Testing: UT

Ticket: #
Signed-off-by: Rajesh Varatharaj <[email protected]>
@routingrocks routingrocks force-pushed the rvaratharaj/pim_mlag_state_fix branch from dd5abf7 to 2eeafae Compare July 29, 2024 22:43
@routingrocks
Copy link
Contributor Author

CI_RUN

@routingrocks routingrocks requested a review from ton31337 July 29, 2024 22:45
@routingrocks
Copy link
Contributor Author

ci:rerun

@ton31337
Copy link
Member

@routingrocks are you going to continue with this?

@routingrocks
Copy link
Contributor Author

@routingrocks are you going to continue with this?

I need to work on this, got fully occupied with the current tasks.

@routingrocks routingrocks marked this pull request as draft December 17, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants