-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Implement match src-peer ... command #16946
Merged
riw777
merged 6 commits into
FRRouting:master
from
opensourcerouting:fix/match_src-peer
Oct 16, 2024
Merged
bgpd: Implement match src-peer ... command #16946
riw777
merged 6 commits into
FRRouting:master
from
opensourcerouting:fix/match_src-peer
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handy when you need to do source matching e.g. `match src-peer ...` on outgoing direction with a route-map. Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/match_src-peer
branch
from
September 27, 2024 19:59
0407300
to
8f0d20d
Compare
To match source peer on the outgoing direction. Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
If using at incoming direction, e.g.: route-map test permit 10 match src-peer 10.0.0.1 ! router bgp 65000 neighbor 10.0.0.1 route-map test in ! Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/match_src-peer
branch
from
September 27, 2024 20:02
8f0d20d
to
6e4bee2
Compare
riw777
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
does the one lint need to be taken care of? it's a line wrap thing ... I'm pretty ambivalent about either format, but just want to make certain we don't add new lints |
yeah, it's annoying, but we intentionally keep such wraps 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.