bfdd: disable echo socket when not using it #16987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzalamena
force-pushed
the
bfd-echo-sock
branch
from
3d7ffd4 to
1b6ea00
Compare
donaldsharp
reviewed
Oct 3, 2024
rzalamena
force-pushed
the
bfd-echo-sock
branch
from
1b6ea00 to
e6720c8
Compare
|
once ci finishes I'll get this in. |
rzalamena
force-pushed
the
bfd-echo-sock
branch
2 times, most recently
from
d1ebd56 to
dc52e52
Compare
riw777
approved these changes
Oct 8, 2024
|
looks like closing this socket is causing bfdd not to be able to "find itself" ... the test probably needs to be changed (?) |
|
ci:rerun |
|
I can confirm that the change helps. Thanks @rzalamena ! |
mjstapp
approved these changes
Oct 21, 2024
|
It's odd it's only failing on docker ... let's try again ci:rerun |
|
I think the CI test needs to be looked at ... probably not going to pass ... |
rzalamena
force-pushed
the
bfd-echo-sock
branch
from
dc52e52 to
88cf860
Compare
rzalamena
force-pushed
the
bfd-echo-sock
branch
from
88cf860 to
2757d58
Compare
Lets avoid a performance penalty in forwarding when not using the BFD echo feature. The echo socket uses raw packet capturing along with a BPF filter which causes performance issues. While here change code to use `-1` for closed sockets instead of valid FD number `0`. Signed-off-by: Rafael Zalamena <[email protected]>
rzalamena
force-pushed
the
bfd-echo-sock
branch
from
2757d58 to
20c3756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16594.
Lets avoid a performance penalty in forwarding when not using the BFD echo feature. The echo socket uses raw packet capturing along with a BPF filter which causes performance issues.