ospf: "no router ospf" has no effect using both vtysh and frr-reload

[c-po]

Description

When instantiating a OSPF configuration, it is not possible to remove the configuration using no router ospf, it keeps on beeing output by vtysh -c "show run"

Version

LR1.wue3# show version
FRRouting 10.1.1 (LR1.wue3) on Linux(6.6.52).

Commit cf5b42e

How to reproduce

LR1.wue3# conf t
LR1.wue3(config)# router ospf
LR1.wue3(config-router)#  auto-cost reference-bandwidth 100
LR1.wue3(config-router)#  timers throttle spf 200 1000 10000
LR1.wue3(config-router)#  max-metric router-lsa on-startup 30
LR1.wue3(config-router)#  max-metric router-lsa on-shutdown 60
LR1.wue3(config-router)#  refresh timer 50
LR1.wue3(config-router)#  aggregation timer 100
LR1.wue3(config-router)#  distance 128
LR1.wue3(config-router)#  distance ospf intra-area 100 external 120
LR1.wue3(config-router)# exit
LR1.wue3(config)# end

LR1.wue3# show run
Building configuration...

Current configuration:
!
frr version 10.1.1
frr defaults traditional
hostname LR1.wue3
log syslog
log facility local7
service integrated-vtysh-config
!
router ospf
 auto-cost reference-bandwidth 100
 timers throttle spf 200 1000 10000
 max-metric router-lsa on-startup 30
 max-metric router-lsa on-shutdown 60
 refresh timer 50
 aggregation timer 100
 distance 128
 distance ospf intra-area 100 external 120
exit
!
end

Now remove configuration using vtysh

LR1.wue3# conf t
LR1.wue3(config)# no router ospf
LR1.wue3(config)# end

Expected behavior

LR1.wue3# show run
Building configuration...

Current configuration:
!
frr version 10.1.1
frr defaults traditional
hostname LR1.wue3
log syslog
log facility local7
service integrated-vtysh-config
!
end

Actual behavior

LR1.wue3# show run
Building configuration...

Current configuration:
!
frr version 10.1.1
frr defaults traditional
hostname LR1.wue3
log syslog
log facility local7
service integrated-vtysh-config
!
router ospf
 auto-cost reference-bandwidth 100
 timers throttle spf 200 1000 10000
 max-metric router-lsa on-startup 30
 max-metric router-lsa on-shutdown 60
 refresh timer 50
 aggregation timer 100
 distance 128
 distance ospf intra-area 100 external 120
exit
!
end

Additional context

No response

Checklist

• I have searched the open issues for this bug.
• I have not included sensitive information in this report.

[ton31337]

As I see in the code, this is intentional due to the max-metric router-lsa on-shutdown command. The timer is activated for X seconds and the config is flushed only when the timer (event) expires.

[c-po]

Interesting - behavior on 9.1 was different. Thanks!

Will re-evaluate this and close if appropriate

[ton31337]

Interesting - behavior on 9.1 was different.

Yes, this 3e2f053 is since 10.0 :)

[c-po]

Behaves as expected with that additional part of knowledge. Thanks again.