ospfd: Fix opaque LSA refresh interval and modify LSA cmds. #17118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceelindem
force-pushed
the
aceelindem/ospf-ls-refresh-interval-fix
branch
3 times, most recently
from
261abd1 to
4ab487f
Compare
donaldsharp
reviewed
Oct 15, 2024
The configured OSPF refresh interval was not being used for opaque LSA (it always used the constant). Also, modified the `timers lsa min-arrival` command to have a maximum of 5000 msecs as well as providing a path for backward command compatibility. Allow added missing user documentation for both `timers lsa min-arrival` and `timers throttle lsa all`. Signed-off-by: Acee Lindem <[email protected]>
aceelindem
force-pushed
the
aceelindem/ospf-ls-refresh-interval-fix
branch
from
4ab487f to
a72c898
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
aceelindem
force-pushed
the
aceelindem/ospf-ls-refresh-interval-fix
branch
from
e543ee7 to
a72c898
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Acee Lindem <[email protected]>
|
Could you drop a merge commit? |
Given that there were rebase conflicts and I committed the merge, this appears to be no easy feat with git (at least with my level of expertise). Closing PR and resubmitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configured OSPF refresh interval was not being used for opaque LSA (it always used the constant). Also, modified the
timers lsa min-arrivalcommand to have a maximum of 5000 msecs as well as providing a path for backward command compatibility.Added missing user documentation for both
timers lsa min-arrivalandtimers throttle lsa all.