*: fix clang-19 SA #17136
Merged
*: fix clang-19 SA #17136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-19's SA complains about unused initializers for this kind of
"switch (enum) { return string }" kind of code. Use direct string
return values to avoid the issue.
Signed-off-by: David Lamparter <[email protected]>
In these cases the value assigned by the switch block is used directly rather than returned. Mark the initial/default value as used so clang-SA doesn't complain about it. Signed-off-by: David Lamparter <[email protected]>
The flex-generated code is disabled for clang-SA builds already, but that means that function prototypes are missing too. Just add dummy function prototypes so clang-SA can process the file. Signed-off-by: David Lamparter <[email protected]>
clang-SA complains that ns->fd could be invalid. Add a guard. Signed-off-by: David Lamparter <[email protected]>
errno is only valid if there was an actual error. A zero return value isn't an error, it's either EOF or an empty datagram depending on context. Fix the logic. Signed-off-by: David Lamparter <[email protected]>
clang-SA complains that it's only partially initialized (because it's used with IPv4 only). The code later calls some AF-generic code, prompting clang-SA to complain that the non-IPv4 parts are used without being set. While this shouldn't happen, just initialize it fully. Signed-off-by: David Lamparter <[email protected]>
The `buf` pointer is being updated as the parse goes along. It's not used after the last update, but I'd rather keep this in for consistency. Just make a note of it being unused. Signed-off-by: David Lamparter <[email protected]>
If a packet doesn't have an interface, we're gonna crash 2 lines below. An assert is a little more useful... and makes clang-SA not complain about it. Signed-off-by: David Lamparter <[email protected]>
If a create-config command is received, but the config is never applied, the config will be leaked on the next create-config command. This should theoretically never happen, but let's fix it anyway. Signed-off-by: David Lamparter <[email protected]>
non-blocking retries are already handled in `vtysh_client_receive()`. And by the point we're back in `vtysh_client_run()`, errno may have been overwritten by the close() call in vtysh_client_receive(). Signed-off-by: David Lamparter <[email protected]>
While the logic here is perfectly fine, clang-SA doesn't understand that the fopen() and fclose() match up with each other. Just use a separate variable to make clang-SA happy. Signed-off-by: David Lamparter <[email protected]>
`FILE *` objects are theoretically in an invalid state if you try to use them past their reporting EOF. Adjust the code to make it correct. Signed-off-by: David Lamparter <[email protected]>
`errno` has its own semantics. Sometimes it is correct to write to it. This is not one of those cases - just use a separate `nl_errno`. Signed-off-by: David Lamparter <[email protected]>
`dirfd()` can theoretically return an error. Call it once and check the result. clang-SA: technically correct™. Ain't that the best kind of correct? Signed-off-by: David Lamparter <[email protected]>
Sigh. clang-SA doesn't want you to call read() while holding a mutex. Signed-off-by: David Lamparter <[email protected]>
|
checkpatch complains about |
|
On a sidenote, the only really ugly "fix" is this one b5f196c If someone wants to go find a better way to go about this… (I'd proceed as is anyway, just to get SA clean, we can always iterate in further PRs.) |
mwinter-osr
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Please wait do not yet merge - need an extra day to debug CI with PR #17137
(Need to test for flag as error if additional error shows up)
(Flagging this as "request changes" to avoid accidental merge and will change once done)
mwinter-osr
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to individual commits for details.
Haven't checked random weird build configurations so there might still be an issue or two on different platforms and/or build options.