isisd: Command "show isis interface IFNAME json" displays all interfaces's circuit id. #17158
Conversation
baozhen-H3C
force-pushed
the
202410180184
branch
from
ffff0b1 to
0af4c91
Compare
baozhen-H3C
force-pushed
the
202410180184
branch
5 times, most recently
from
cf57446 to
4430811
Compare
| @@ -955,6 +955,8 @@ void isis_circuit_print_json(struct isis_circuit *circuit, | |||
| char buf_prx[INET6_BUFSIZ]; | |||
| char buf[255]; | |||
|
|
|||
| json_object_int_add(json, "circuit", circuit->circuit_id); | |||
There was a problem hiding this comment.
why add this value a second time, with a new key - isn't it being added just below with "circuit-id"?
There was a problem hiding this comment.
I want to print the circuit_id only when printing a specific interface, if this modification is allowed.
baozhen-H3C
force-pushed
the
202410180184
branch
2 times, most recently
from
09dc643 to
0a845f7
Compare
|
@baozhen-H3C please put the description in the commit, not in the PR's description. |
|
So, is this change only to skip showing circuits that do not have any interfaces assigned? |
|
@ton31337 Yes, it now seems unnecessary.Perhaps what I'm doing is pointless. |
baozhen-H3C
force-pushed
the
202410180184
branch
from
0a845f7 to
ed2dfdf
Compare
TBH, this is kinda of a breaking change (at some level). |
baozhen-H3C
force-pushed
the
202410180184
branch
from
6f7b7ce to
8a67c5f
Compare
… ID of all interfaces
1.before the commit
if the interface exists:
sonic# show isis interface lo json
{
"areas":[
{
"area":"10",
"circuits":[
{
"circuit":13
},
{
"circuit":14
},
{
"circuit":0,
"interface":{
"name":"lo",
"state":"Up",
"is-passive":"passive",
"circuit-id":"0x0",
"type":"loopback",
"level":"L1",
"levels":[
{
"level":"L1",
"metric":10
}
],
"ip-prefix":{
"ip":"7.7.7.7/32"
}
}
}
]
}
]
}
if the interface doesn't exist:
sonic# show isis interface abc json
{
"areas":[
{
"area":"10",
"circuits":[
{
"circuit":13
},
{
"circuit":14
},
{
"circuit":0
}
]
}
]
}
2.after the commit
if the interface exists:
sonic# show isis interface lo json
{
"areas":[
{
"area":"10",
"circuits":[
{
"circuit":0,
"interface":{
"name":"lo",
"state":"Up",
"is-passive":"passive",
"circuit-id":"0x0",
"type":"loopback",
"level":"L1",
"levels":[
{
"level":"L1",
"metric":10
}
],
"ip-prefix":{
"ip":"7.7.7.7/32"
}
}
}
]
}
]
}
if the interface doesn't exist:
sonic# show isis interface abc json
{
"areas":[
{
"area":"10",
"circuits":[
]
}
]
}
Signed-off-by: baozhen-H3C <[email protected]>
|
seems like this is pointless now (?) ... I'll set it to autoclose, please comment if this is still needed |
|
@frrbot autoclose in 1 month |
It's ok, let it autoclose. |
|
This issue will no longer be automatically closed. |
The change is only to skip showing circuits that do not have any interfaces assigned.