isisd: fix 'show isis route' and 'show isis fast-reroute summary' errors with vrf #17174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you move the analysis put in the PR into the commit message? It's not useful in the PR long term. |
…ors with vrf
When the VRF does not exist, the command will display results for the 'default' VRF.
1.before the commit:
sonic# show vrf
vrf Vrf1 id 41 table 1001
sonic# show isis vrf abc route level-1
Area 10:
IS-IS L1 IPv4 routing table:
Prefix Metric Interface Nexthop Label(s)
-------------------------------------------------------
0.0.0.0/0 5 Ethernet0 10.1.1.2 -
6.6.6.6/32 10 - - -
sonic# show isis vrf abc fast-reroute summary level-1
Area 10:
IS-IS L1 IPv4 Fast ReRoute summary:
Protection \ Priority Critical High Medium Low Total
--------------------------------------------------------------------------
Classic LFA 0 0 2 3 5
Remote LFA 0 0 0 0 0
Topology Independent LFA 0 0 0 0 0
ECMP 0 0 0 0 0
Unprotected 0 0 2 2 4
Protection coverage 0.00% 0.00% 50.00% 60.00% 55.56%
2.after the commit:
sonic# show vrf
vrf Vrf1 id 41 table 1001
sonic# show isis vrf abc route level-1
sonic# show isis vrf abc fast-reroute summary level-1
What I do:
Move 'ISIS_FIND_VRF_ARGS(argv, argc, idx, vrf_name, all_vrf);' to the front, otherwise changing 'idx' while searching for other parameters may result in failing to find the vrf parameter.
Signed-off-by: baozhen-H3C <[email protected]>
baozhen-H3C
force-pushed
the
202410180225
branch
from
57c0fe2 to
e2e4894
Compare
|
@donaldsharp I have updated it. |
|
it might have been easier with a little more description ... but ... :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.