Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: Add missing libprotobuf-dev to grpc profile #17205

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

piotrjurkiewicz
Copy link
Contributor

Configure fails without libprotobuf-dev package. protobuf-compiler package recommends libprotobuf-dev, but this is a soft-dependency, so it needs to be added explicitly.

Also correct tabs/spaces issues introduced by the original patch.

@frrbot frrbot bot added the packaging label Oct 23, 2024
@piotrjurkiewicz piotrjurkiewicz changed the title Add missing libprotobuf-dev build dependency to grpc profile debian: Add missing libprotobuf-dev to grpc profile Oct 23, 2024
debian/control Outdated Show resolved Hide resolved
debian/control Outdated Show resolved Hide resolved
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337
Copy link
Member

ton31337 commented Nov 8, 2024

@Mergifyio backport dev/10.2

@ton31337 ton31337 added this to the 10.2 milestone Nov 8, 2024
Copy link

mergify bot commented Nov 8, 2024

backport dev/10.2

❌ No backport have been created

  • Backport to branch dev/10.2 failed

GitHub error: Branch not found

@Jafaral Jafaral merged commit dfd85da into FRRouting:master Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants