tests: add bgp_vpnv4_route_leak_basic #17369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Please replace per-daemon configs with unified (frr.conf). https://docs.frrouting.org/projects/dev-guide/en/latest/topotests.html#writing-tests
louis-6wind
force-pushed
the
bgp_vpnv4_route_leak_basic
branch
from
3778419 to
7422092
Compare
Done |
|
unified conf set. @ton31337 are you satisfied with the PR now ? |
ton31337
approved these changes
Nov 20, 2024
ton31337
reviewed
Nov 20, 2024
tests/topotests/bgp_vpnv4_route_leak_basic/test_bgp_vpnv4_route_leak_basic.py
Outdated
Show resolved
Hide resolved
bgp_vrf_route_leak_basic uses "import/export vrf" commands to perform route leaks between VRF on the r1 router. The same result can be achieved by using the "route-target import / export" commands. Copy bgp_vrf_route_leak_basic to bgp_vpnv4_route_leak_basic. Change BGP configuration to handle the route leaks with "route-target import / export". Change to retry timers. No other changes. Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
bgp_vpnv4_route_leak_basic
branch
from
7422092 to
82a540d
Compare
|
ci:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgp_vrf_route_leak_basic uses "import/export vrf" commands to perform route leaks between VRF on the r1 router. The same result can be achieved by using the "route-target import / export" commands.
Copy bgp_vrf_route_leak_basic to bgp_vpnv4_route_leak_basic. Change BGP configuration to handle the route leaks with "route-target import / export". Change to retry timers. No other changes.
This new test will be used as a basis to fix VPN table issues