zebra: Fix ip protocol route-map issue. #17474
Open
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need a topotest to check such a foobar? |
|
I'm not sure matters a whole bunch for this case |
Yes, I am adding topotest also |
sougata-github-nvidia
force-pushed
the
rib_ip_protocol_cleanup
branch
from
a036be1 to
d349867
Compare
|
@riw777 I have also added topotest . Can you please review my changes ? |
@ton31337 Added |
sougata-github-nvidia
force-pushed
the
rib_ip_protocol_cleanup
branch
from
d349867 to
d0a47a3
Compare
|
@sougata-github-nvidia please fix frrbot and let's merge it. |
"ip/ipv6 protocol any route-map <route map>" cli is setting wrong route type ( ZEBRA_ROUTE_MAX ), It should set route type ZEBRA_ROUTE_ALL. Ticket: #4101560 Signed-off-by: Sougata Barik <[email protected]>
sougata-github-nvidia
force-pushed
the
rib_ip_protocol_cleanup
branch
from
d0a47a3 to
86b2946
Compare
@ton31337 I have fixed the frrbot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ip/ipv6 protocol any route-map " cli is setting wrong route type (ZEBRA_ROUTE_MAX), It should set route type ZEBRA_ROUTE_ALL.
After executing the above CLI, routes are not scheduled for processing with routemap.
Reason: CLI set route-type=ZEBRA_ROUTE_MAX but Zebra checks ZEBRA_ROUTE_ALL in rib_update_route_node().
FRR restart solves the issue, and filter works as expected, because restart route install flow is different and its checks are proper.
After this code change all the api's are in synced, and right FLAG is used.
CLI, rib_update_route_node() , zebra_route_map_check ()
Ticket: #4101560