zebra: fix wrong nexthop status for kernel routes #17544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me, it looks like separate commits should be used for these somewhat relative issues. Also, can you create a topotest covering this case? |
2 tasks
anlancs
force-pushed
the
zebra/fix-plug-interface
branch
from
b2834cd to
9b5738f
Compare
The kernel routes are wrongly selected even the nexthop interface is linkdown. Use `ip link set dev <interface> down` on the other box to set the box's nexthop interface linkdown. The kernel routes will be kept as `linkdown`, but are still with active nexthop in `zebra`. Add three changes/commits for kernel routes in this PR: 1) The active nexthop should be the operative interface. 2) Don't uninstall the kernel routes from `zebra` even no active nexthops. (It doesn't affect the kernel routes' deletion from kernel netlink messages.) 3) Update the kernel routes when the nexthop interface becomes up. Before: (during nexthop interface is linkdown) ``` K>* 3.3.3.3/32 [0/0] via 88.88.88.1, enp2s0, weight 1, 00:00:14 ``` After: (during nexthop interface is linkdown, with all three changes) ``` K 3.3.3.3/32 [0/0] via 88.88.88.1, enp2s0 inactive, weight 1, 00:00:07 ``` This commit is 1st change: Improve the judgment for "active" nexthop to be more accurate, the active nexthop should be the operative interface. Signed-off-by: anlan_cs <[email protected]>
After the nexthop check is fixed, zebra will wrongly uninstall the kernel routes with inactive nexthop. This commit would skip the uninstallation for kernel routes. Signed-off-by: anlan_cs <[email protected]>
Just like `link down`, check all kernel routes when interface become up. And, they maybe will be selected as the best one by zebra. Signed-off-by: anlan_cs <[email protected]>
Signed-off-by: anlan_cs <[email protected]>
anlancs
force-pushed
the
zebra/fix-plug-interface
branch
from
9b5738f to
2f1bd3f
Compare
|
@riw777 Are there any plans to backport this fix to stable/10.2 branch? |
2 tasks
|
@riw777 as stable/9.1 is affected, too - can this be backported there as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel routes are wronlgy active even the nexthop interface is linkdown.
Use
ip link set dev <interface> downon the other box to set the box'snexthop interface linkdown. The kernel routes will be kept as
linkdown,but are still with active nexthop in
zebra.Add three changes for kernel routes in this commit:
zebraeven no active nexthops.(It doesn't affect the kernel routes' deletion from kernel netlink messages.)
Before: (during nexthop interface is linkdown)
After: (during nexthop interface is linkdown)