CLI: Added line permutation check for file loaded config #17693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes instructions in the loaded config does not match the same instructions in the running config. In this case frr-reload.py removes the line. For example: pppoe-server(config-vrf)# ip route 10.0.0.0/8 blackhole tag 220 250 pppoe-server(config-vrf)# ip route 10.0.0.0/8 blackhole 250 tag 220 This leads to config loss and unpredictable FRR functionality. Signed-off-by: Yaroslav Kholod <[email protected]>
|
Is there anything wrong with the PR? I believe related issue is important -- #17606 I am open to the discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes instructions in the loaded config does not match the same instructions in the running config. In this case frr-reload.py removes the line.
For example:
pppoe-server(config-vrf)# ip route 10.0.0.0/8 blackhole tag 220 250 pppoe-server(config-vrf)# ip route 10.0.0.0/8 blackhole 250 tag 220
This leads to config loss and unpredictable FRR functionality.