tests: cleanup ospf6 ecmp inter area #17707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why open this instead of amending #16811 and continue the work there? |
|
Because @louis-6wind said that he doesn't have time to complete #16811 and I don't have write access there (at least if I understand correctly how github handles PRs internally) |
|
Oh, I see, thanks, I missed Lous was the author. |
|
Can you fix the syling (frrbot)? |
Use router_json_cmp when checking for proper nexthops to get better
diagnostics in case of mismatches. Add step() messages to see which check
failed.
Based on original PR#16811 commit:
expect_num_nexthops() errors are not understandable.
Use router_json_cmp.
Signed-off-by: Louis Scalbert <[email protected]>
Signed-off-by: Martin Buck <[email protected]>
Drop eth3 shutdown from ospf6d.conf - it doesn't do anything there. And it
actually shouldn't do anything: eth3 on r7/r8 are used as loopback-like
interfaces to inject the address on eth2 into OSPFv3. So they need to be up
for eth2 to work as expected.
Based on original PR#16811 commit:
eth3 shutdown is not applied because it is ospf6d.conf.
Signed-off-by: Louis Scalbert <[email protected]>
Signed-off-by: Martin Buck <[email protected]>
gromit1811
force-pushed
the
pr16811_rebased
branch
from
638ab7c to
09d66b9
Compare
|
Ah, didn't notice that. Fixed. CI failed the first time, which is not impossible but pretty unlikely given the rareness of the bug this test case checks. Let's see whether it succeeds this time. If it fails again, there might be a bug in the routes the test case compares against. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces/supersedes #16811. Addresses all review comments.
Compare JSON routes to check for success instead of counting nexthops. Also fix bad interface shutdown config.
Note that like #16811, this does not fix intermittent test case failures. These are actual ospf6d errors, not test case bugs. See #16197 for details, in particular comments starting at #16197 (comment)