BGP Optimal Route Reflector Support

[brotherdust]

Hi, folks!
Any plans to support https://tools.ietf.org/html/draft-ietf-idr-bgp-optimal-route-reflection-16?

If I'm reading the draft correctly: optimize the paths a route reflector sends to an RR client based on where the client is in the network instead of where the RR server is. Accomplished by reading IGP topology and re-computing with the RR client as root of the tree.

Juniper and Cisco have working implementations of it, so it's definitely out there.

What say you? =)

[donaldsharp]

Opened a FR in the wiki

[brotherdust]

RFC version 17 is now in effect. Providing a link here for convenience.
https://tools.ietf.org/html/draft-ietf-idr-bgp-optimal-route-reflection-17

Expires April 13, 2019

[brotherdust]

RFC version 20 is now in effect. Providing link here for convenience.
https://tools.ietf.org/html/draft-ietf-idr-bgp-optimal-route-reflection-20

Expires 2019-07-11

[maduri111]

Hi,

draft version 21 is now in effect.
https://tools.ietf.org/html/draft-ietf-idr-bgp-optimal-route-reflection-21

Expires 2020-12-18

Anyone working on this FR ? if not, Shall I start working this feature support ?

[brotherdust]

Hi,

draft version 21 is now in effect.

https://tools.ietf.org/html/draft-ietf-idr-bgp-optimal-route-reflection-21

Expires 2020-12-18

Anyone working on this FR ? if not, Shall I start working this feature support ?

To my knowledge, no one has worked on it. I don’t have the skills to do it, otherwise I would have done it. However, I’m happy to write the documentation for it if you’d like to collaborate.

[maduri111]

Thanks for the update. would let you know when I need your help.

[brotherdust]

@maduri111 hey just wanted to check in and see how things are going with your work on this feature request! Excited to hear back from you! Thanks!

[maduri111]

@maduri111 hey just wanted to check in and see how things are going with your work on this feature request! Excited to hear back from you! Thanks!

@brotherdust Hi, Currently working on BGP conditional advertisement feature. So will resume on this from Oct 1st and probably by October end i will send the code changes.

[brotherdust]

@maduri111 ok! Thanks for the update!

I'd like to get a head-start on documentation (if you're still interested!) so it's ready on day 1. If possible, can you give me read-only access or a link to the repo you'll be working in for this feature?

Thanks much!

[fcastello]

It is not clear if this has been implemented or not. Is there a link to follow the FR in the wiki?

[maduri111]

@fcastello
Its not implemented yet. Planning to complete it by October end.

[maduri111]

@maduri111 ok! Thanks for the update!

I'd like to get a head-start on documentation (if you're still interested!) so it's ready on day 1. If possible, can you give me read-only access or a link to the repo you'll be working in for this feature?

Thanks much!

@brotherdust
You could start with documentation. that would be helpful.
Will give you the access to my repo, once I start committing the changes to this feature branch.

Thanks.

[brotherdust]

@maduri111 Just checking in! Have you made enough progress that I can begin working on docs?
Thanks much!

[brotherdust]

@maduri111 Checking in again. Please let me know what I can do to help! Thanks!

[maduri111]

@brotherdust Sorry, due to personal emergency could not work on this. Will be working on this from next week. Once I complete the CLI part, or make some significant progress, will ping you. Thanks !

[brotherdust]

@maduri111 No problem! Whatever the emergency was, I hope things are better now. I am looking forward to working with you!

[brotherdust]

Hi @maduri111! Just wanted to check in with you again. It's almost February! How time flies!

[maduri111]

@brotherdust Right. Working on this. Thanks!

[brotherdust]

@maduri111 , just wanted to check in with you again. Are you ready to give me access so I can start working on docs? Very eager to get this feature into FRR as I have a very good use-case for it.

Please let me know. Thanks!

[brotherdust]

@maduri111 , just checking in again! Hope you are well!

[maduri111]

@brotherdust I am doing good. Thank you.
Sorry It got delayed due to other internal projects.
As you know, for updating document we need to provide the output of the test cases. So documentation can be done after completing testing. I will send you an email with the branch details once coding & testing is done.

[brotherdust]

@maduri111
Any news here? Just checking in! Thanks!

[brotherdust]

@maduri111 this issue got linked to from an ipspace.net blog article.

You're famous! 😀

[maduri111]

@brotherdust Oh that's bad :)

[brotherdust]

@maduri111 , just doing my usual check-in. You committed to this feature quite a while ago. I understand your time is limited and valuable, so if it's not going to happen and you want me to stop bothering you, please say so.
Thank you!

[maduri111]

@brotherdust No you are not bothering, Thanks for checking the status.
As of now, CLI, Zebra,ospf and bgp interaction, route table modification in route-reflector based on active root is working fine.
Also addressed comments posted in #9002

Separate BGP tables creation(for different ORR groups and non ORR groups) and topo tests creation pending.
Resumed working on that. Will ping you back once its done.

Thanks

[brotherdust]

Thank you for responding so quickly; and thank you for the link to the pull request. Do you think there's enough to get started on the docs?

[maduri111]

@brotherdust better to start after completing "separate BGP tables creation(for different ORR groups and non ORR groups)"

[brotherdust]

@maduri111 ok! Thanks again!

[brotherdust]

@maduri111 just checking in again! Hope are well!

[brotherdust]

@maduri111 sorry pressed submit too soon. I looked at the commit history on the referenced repo and it looks like work stopped about 10 months ago (I can't find anything more recent). If this is the case, what is missing from the implementation at present? I'm just trying to think of ways I can help push this over the finish line. 😁

[brotherdust]

@maduri111
It's that time of year again! Just checking in on your progress. Any news would be appreciated! Thank you!

[maduri111]

@maduri111 It's that time of year again! Just checking in on your progress. Any news would be appreciated! Thank you!

@brotherdust

Sorry for the late reply and forgot to update you on this.

code changes for the basic BGP ORR functionality is merged with the below PR.
#11159

Now, the BGP RR with ORR config, calculates the best route from one of its root RR client's location and sends update to all clients.

Below are pending:

1. BGP best route for different/non ORR group should be separated.
2. topo tests are pending.
   Planning to start after completing 1.
   if you are interested you can start with that. I will push/send the topology and configuration required.

Thanks

[brotherdust]

@maduri111

I'm interested! I see you already wrote the docs, which were included in the merge. Nice work!

I'll get to work as soon as I have the parts you mentioned!

[brotherdust]

@maduri111 Just want to make sure I'm understanding correctly: you want me to create topotests? If so, I've never done that before, but I'm willing to give it a go.