zebra: cleanup netlink_ipneigh_change #9827
Conversation
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
idryzhov
force-pushed
the
netlink_ipneigh_change-cleanup
branch
from
2316d11 to
69b7bf9
Compare
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-805/ This is a comment from an automated CI system. |
Don't parse netlink messages twice, and don't mix parsing and processing code. First, parse the message, then process it. Signed-off-by: Igor Ryzhov <[email protected]>
idryzhov
force-pushed
the
netlink_ipneigh_change-cleanup
branch
from
69b7bf9 to
90fd0b3
Compare
|
@donaldsharp hi, you asked for this cleanup, would be great to get a review when you have time. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3244/ This is a comment from an automated CI system. |
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| netlink_nbr_entry_state_to_zclient(ndm->ndm_state), l2_data, | ||
| l2_len); | ||
|
|
||
| if (h->nlmsg_type == RTM_GETNEIGH) |
There was a problem hiding this comment.
This code is not 1:1 functionality with the previous one. Suggestion: make this if into a switch and reject anything other than RTM_NEWNEIGH, RTM_DELNEIGH.
Here is what the previous remove code did (right above these lines addition):
if (h->nlmsg_type == RTM_NEWNEIGH)
cmd = ZEBRA_NHRP_NEIGH_ADDED;
else if (h->nlmsg_type == RTM_GETNEIGH)
cmd = ZEBRA_NHRP_NEIGH_GET;
else if (h->nlmsg_type == RTM_DELNEIGH)
cmd = ZEBRA_NHRP_NEIGH_REMOVED;
else {
zlog_debug("%s(): unknown nlmsg type %u", __func__,
h->nlmsg_type);
return 0;
}
|
Too many changes in master since this code was written. Closing. |
Don't parse netlink messages twice, and don't mix parsing and processing
code. First, parse the message, then process it.
Signed-off-by: Igor Ryzhov [email protected]