From 61ff7dddfae1ef0869818191c5d838aa6d1bdc8f Mon Sep 17 00:00:00 2001 From: Donatas Abraitis <donatas@opensourcerouting.org> Date: Fri, 1 Dec 2023 10:35:19 +0200 Subject: [PATCH] bgpd: Do not null-terminate the domainname when receiving FQDN capability This is already handled above, no need to do here, because we could have an overrun situation where len > 64 and we do out-of-bound actions. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org> --- bgpd/bgp_packet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c index 5dc35157ebf6..601dac7970c6 100644 --- a/bgpd/bgp_packet.c +++ b/bgpd/bgp_packet.c @@ -3339,8 +3339,6 @@ static void bgp_dynamic_capability_fqdn(uint8_t *pnt, int action, data += len; if (len) { - str[len] = '\0'; - XFREE(MTYPE_BGP_PEER_HOST, peer->domainname); peer->domainname = XSTRDUP(MTYPE_BGP_PEER_HOST, str);