From 0f7b5fcffb8322dc925d43b062048d50bf53cffc Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 15 Feb 2024 23:27:38 -0500 Subject: [PATCH 1/2] ospfd: Fix assignment with never being used SA finds this: error 14-Feb-2024 14:52:24 ospfd/ospf_te.c:3962:2: warning: Value stored to 'sub' is never read [deadcode.DeadStores] error 14-Feb-2024 14:52:24 sub = 0; error 14-Feb-2024 14:52:24 ^ ~ error 14-Feb-2024 14:52:24 1 warning generated. Signed-off-by: Donald Sharp --- ospfd/ospf_te.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ospfd/ospf_te.c b/ospfd/ospf_te.c index 9ba9a7659d6f..a55a37a9077b 100644 --- a/ospfd/ospf_te.c +++ b/ospfd/ospf_te.c @@ -3959,7 +3959,6 @@ static void ospf_mpls_te_show_info(struct vty *vty, struct json_object *json, json_object *jobj = NULL; sum = 0; - sub = 0; total = lsa->size - OSPF_LSA_HEADER_SIZE; for (tlvh = TLV_HDR_TOP(lsah); sum < total && tlvh; From 863e6ddf11a312821d3686813ed73ccc6bb35af6 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 15 Feb 2024 23:28:18 -0500 Subject: [PATCH 2/2] bgpd: Fix value stored to group never being read SA Reports: bgpd/bgp_rpki.c:1085:24: warning: Value stored to 'group' during its initialization is never read [deadcode.DeadStores] struct rtr_mgr_group *group = get_connected_group(rpki_vrf); ^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Donald Sharp --- bgpd/bgp_rpki.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_rpki.c b/bgpd/bgp_rpki.c index 22f78fb80a93..56b0263bf691 100644 --- a/bgpd/bgp_rpki.c +++ b/bgpd/bgp_rpki.c @@ -1082,7 +1082,7 @@ static void print_prefix_table(struct vty *vty, struct rpki_vrf *rpki_vrf, unsigned int number_of_ipv4_prefixes = 0; unsigned int number_of_ipv6_prefixes = 0; - struct rtr_mgr_group *group = get_connected_group(rpki_vrf); + struct rtr_mgr_group *group; json_object *json_records = NULL; if (!rpki_vrf)