From c8e83c3bfd94fa6a5a2ea85a8d374aae3a48980a Mon Sep 17 00:00:00 2001 From: Carmine Scarpitta Date: Sun, 24 Nov 2024 09:37:22 +0100 Subject: [PATCH] tools: Add missing keyword `encapsulation` in frr-reload Consider the following scenario. You start from the configuration below: ``` ! segment-routing srv6 encapsulation source-address fc00:0:1::1 ! ! ! ``` Then you change the source address: ``` r1# configure r1(config)# segment-routing r1(config-sr)# srv6 r1(config-srv6)# encapsulation r1(config-srv6-encap) source-address 1::1 ``` And finally, reload the configuration `python3 frr-reload.py --reload /etc/frr/frr.conf` frr-reload returns the error below: ``` Failed to execute segment-routing srv6 no source-address 1::1 exit exit "segment-routing -- srv6 -- no source-address 1::1 -- exit -- exit" we failed to remove this command % Unknown command: no source-address 1::1 [79975|mgmtd] sending configuration line 3: % Unknown command[76]: source-address fc00:0:1::1 [79975|mgmtd] Configuration file[/etc/frr/frr.conf] processing failure: 2 ``` The reason is that the keyword `encapsulation` is missing in frr-reload. This patch adds the missing keyword `encapsulation`. Signed-off-by: Carmine Scarpitta --- tools/frr-reload.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/frr-reload.py b/tools/frr-reload.py index 33d6cf04444b..2bb364f32b00 100755 --- a/tools/frr-reload.py +++ b/tools/frr-reload.py @@ -279,7 +279,7 @@ def get_normalized_interface_vrf(line): "policy ": {"candidate-path ": {}}, "pcep": {"pcc": {}, "pce ": {}, "pce-config ": {}}, }, - "srv6": {"locators": {"locator ": {}}}, + "srv6": {"locators": {"locator ": {}}, "encapsulation": {}}, }, "nexthop-group ": {}, "route-map ": {},