Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates parsed two times #309

Open
FRosner opened this issue Oct 27, 2017 · 1 comment
Open

Templates parsed two times #309

FRosner opened this issue Oct 27, 2017 · 1 comment
Milestone

Comments

@FRosner
Copy link
Owner

FRosner commented Oct 27, 2017

I restarted Broccoli and then many clients reconnected at the same time. Looks like two triggered parsing templates at once. Should we synchronize the code?

15:33:09.256 INFO de.frosner.broccoli.templates.DirectoryTemplateSource - Successfully parsed 18 templates: ...
15:33:09.257 INFO de.frosner.broccoli.templates.DirectoryTemplateSource - Successfully parsed 18 templates: ...
@FRosner FRosner added this to the 0.8.0 milestone Oct 27, 2017
@FRosner
Copy link
Owner Author

FRosner commented Nov 20, 2017

Looks like the reason is that plays @Singleton annotation only guarantees that only one instance of the singleton object lives at the same time but it does not guarantee that multiple are constructed!

@FRosner FRosner modified the milestones: 0.8.0, 0.9.0 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant