Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broccoli HTTP requests time out #334

Closed
FRosner opened this issue Nov 21, 2017 · 3 comments · Fixed by #338
Closed

Broccoli HTTP requests time out #334

FRosner opened this issue Nov 21, 2017 · 3 comments · Fixed by #338
Milestone
0.8.0

Comments

@FRosner
Copy link
Owner

FRosner commented Nov 21, 2017 •
edited
Loading

Problem

After some time of having Broccoli running with many users and instances, the consul health check fails, Broccoli becomes unresponsive.

References
@FRosner FRosner added this to the 0.8.0 milestone Nov 21, 2017
@FRosner
Copy link
Owner Author

FRosner commented Nov 21, 2017

Am I using the websocket channels correctly?
https://stackoverflow.com/questions/24576405/broadcasting-messages-in-play-framework-websockets

@FRosner
Copy link
Owner Author

FRosner commented Nov 21, 2017

The channel broadcast is blocking. So maybe we can also move to fixed delay and log the time.

FRosner added a commit that referenced this issue Nov 21, 2017
@FRosner
#334 log the time it takes to update the websocket clients
f2c7298
FRosner added a commit that referenced this issue Nov 21, 2017
@FRosner
#334 schedule websocket updates with fixed delay instead of at fixed …
bf1462c 
…rate
FRosner added a commit that referenced this issue Nov 21, 2017
@FRosner
#334 log total number of channels
c1c0131
@FRosner
Copy link
Owner Author

FRosner commented Nov 22, 2017

Maybe I should use a unicast instead of multicasts for everyone? As I am anyway sending the message separately for authorization reasons (some users cannot receive passwords, e.g.).

https://stackoverflow.com/questions/23371586/understanding-concurrent-unicasts-arguments

@FRosner FRosner mentioned this issue Nov 27, 2017
Merged
FRosner added a commit that referenced this issue Nov 27, 2017
@FRosner
Merge pull request #338 from FRosner/frosner/GH-334-unresponsive
a5d3c69 
#334 websocket fixed delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

#334 websocket fixed delay FRosner/cluster-broccoli
1 participant
@FRosner