You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Docker tests currently require docker hub credentials and any contribution made from a fork fails the test making the CI not very reliable unless you look at the logs. Maybe we should push to docker hub only when a request is merged to master.
The text was updated successfully, but these errors were encountered:
Yes the Docker push should only be executed if the branch is NOT a pull request coming from external. I think Travis injects an environment variable to determine whether it's an internal branch or an external PR.
We cannot push only on master as we make use of the tags from branches for test deployments as well.
The Docker tests currently require docker hub credentials and any contribution made from a fork fails the test making the CI not very reliable unless you look at the logs. Maybe we should push to docker hub only when a request is merged to master.
The text was updated successfully, but these errors were encountered: