Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove Docker tests #369

Open
sohaibiftikhar opened this issue May 17, 2018 · 1 comment
Open

Fix/remove Docker tests #369

sohaibiftikhar opened this issue May 17, 2018 · 1 comment

Comments

@sohaibiftikhar
Copy link
Collaborator

The Docker tests currently require docker hub credentials and any contribution made from a fork fails the test making the CI not very reliable unless you look at the logs. Maybe we should push to docker hub only when a request is merged to master.

@FRosner
Copy link
Owner

FRosner commented May 17, 2018

Yes the Docker push should only be executed if the branch is NOT a pull request coming from external. I think Travis injects an environment variable to determine whether it's an internal branch or an external PR.

We cannot push only on master as we make use of the tags from branches for test deployments as well.

Would you like to make that change, @sohaibiftikhar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants