Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary parameter renaming #172

Open
wintersteiger opened this issue Feb 21, 2020 · 0 comments
Open

Unnecessary parameter renaming #172

wintersteiger opened this issue Feb 21, 2020 · 0 comments

Comments

@wintersteiger
Copy link

Kremlin often renumbers function parameters when it's not really necessary (or at least not obvious why it is necessary). For instance, i1 on mt_create here: https://github.com/project-everest/hacl-star/blob/3cc6ce0ce91ce41fddb328aa809df234e6185eff/dist/gcc64-only/MerkleTree.h#L95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wintersteiger