Remove C89 distribution. This fixes #522 #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polubelova
approved these changes
Oct 25, 2022
R1kM
approved these changes
Oct 25, 2022
|
For some reason, I had forgotten to push my changes to Makefile. I also fixed the doc. The only remaining occurrence of c89 is thus the one for election guard, and I'll see about that with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale.
The one mode that matters is the MSVC mode, but for that we have -fmsvc.
Maybe the ElectionGuard folks need ancient compiler compatibility, but I'm not even sure about that. I can check.
In any case I'd feel better removing this now that we have code in the tree that triggers FStarLang/karamel#283