Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching of Objects when created with __init__ #47

Open
FUMR-bot opened this issue Sep 14, 2020 · 1 comment
Open

Fix caching of Objects when created with __init__ #47

FUMR-bot opened this issue Sep 14, 2020 · 1 comment

Comments

@FUMR-bot
Copy link
Contributor

FUMR-bot commented Sep 14, 2020


This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:17. It will automatically be closed when the TODO comment is removed from master.

FUMR-bot pushed a commit that referenced this issue Sep 14, 2020
@JuniorJPDJ
Copy link
Contributor

JuniorJPDJ commented May 20, 2021

Now albums loaded from obj props are not cached, any search result is not cached too.

I tried recreating every object based on id but sometimes playlists and probably other collections can contain unreachable track (region locked) and result in 404 exception when loading collection - this is unacceptable.

Probably some custom caching impl is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants