Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Button Stopped Working #210

Open
martindale opened this issue Aug 1, 2017 · 3 comments
Open

Edit Button Stopped Working #210

martindale opened this issue Aug 1, 2017 · 3 comments

Comments

@martindale
Copy link
Member

martindale commented Aug 1, 2017 •
edited
Loading

Daily reminder to write tests for the UI when we migrate to Maki 0.3. This issue is on the player page (views/room.jade or views/index.jade IIRC), where tracks in the queue cannot be edited ahead of time. Requires the editor editor role.

Bounty: 3QA6eg4xLbFoUcChFtboQbzCPwyCCuxg66
@martindale martindale mentioned this issue Aug 1, 2017
Open
@martindale
Copy link
Member Author

The edit button seems to be working again. No changes. Mystery fix?

@martindale
Copy link
Member Author

This is very bizarre — every time I visit Europe, the button seems to start working again. When switching to an American IP address, the edit button ceases to work.

Consider me puzzled.

@martindale
Copy link
Member Author

Mentioned in isaacs/github#986. Forever curious, but re-writing. Will test again when travel opens up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martindale