Create an MRJ to set the classloader name #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfPlayer1
approved these changes
Sep 18, 2024
Gamebuster19901
suggested changes
Oct 1, 2024
| @@ -51,7 +51,7 @@ public void addURL(URL url) { | |||
| private final KnotClassDelegate<KnotClassLoader> delegate; | |||
|
|
|||
| KnotClassLoader(boolean isDevelopment, EnvType envType, GameProvider provider) { | |||
| super(new DynamicURLClassLoader(new URL[0])); | |||
| super("knot", new DynamicURLClassLoader(new URL[0])); | |||
There was a problem hiding this comment.
Perhaps something like 'fabric-knot' would be more clear.
It would be nice to encourage a naming convention that makes it clear which classloader is being specified, AND where it comes from.
There was a problem hiding this comment.
This is sort of a feature, calling it anything fabric would just mislead people with their mod issues, while the information itself is mostly useful and actionable for those that mostly tend to know what Knot is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the class loader name, this means stacktraces indicate what classloader a given class was loaded from.
Questions:
fabricoverknotas this will be seen by anyone looking at log files, knot is very much an internal name to loader, with little meaning.