Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loot modifiers will be applied multiple times in the case of nested loot tables #163

Open
Karashok-Leo opened this issue Feb 12, 2025 · 0 comments
Open

Loot modifiers will be applied multiple times in the case of nested loot tables #163

Karashok-Leo opened this issue Feb 12, 2025 · 0 comments

Comments

@Karashok-Leo
Copy link

Porting lib modifies this method:
net.minecraft.world.level.storage.loot.LootTable#getRandomItemsRaw
via mixin in order to implement loot modifiers, which is also called in net.minecraft.world.level.storage.loot.entries.NestedLootTable#createItemStack

The logical thing to do would be to modify this method:
net.minecraft.world.level.storage.loot.LootTable#getRandomItems
like forge did
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Karashok-Leo