Skip to content

Commit 7348516

Browse files
authored
Links fix (#94)
* Fix dark mode link contrast * Disclaimer split * Adjust dark mode color again
1 parent dd421fc commit 7348516

File tree

6 files changed

+34
-14
lines changed

6 files changed

+34
-14
lines changed

app.scss

+7-1
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,16 @@
9898
border-top-right-radius: 0px !important;
9999
}
100100

101-
.markdown-body a {
101+
.markdown-body a,
102+
.link-rows a {
102103
color: var(--color-brand) !important;
103104
}
104105

106+
html.dark .markdown-body a,
107+
html.dark .link-rows a {
108+
color: var(--color-brand-dark) !important;
109+
}
110+
105111
.centered-hero {
106112
// Center everything along a column.
107113
display: flex;

app.vue

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ useHeadSafe({
3939
4040
:root {
4141
--color-brand: #785A00 !important;
42+
--color-brand-dark: #AD8200 !important;
4243
}
4344
4445
.page {

components/Footer.vue

-4
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ import { Avatar } from "omorphia";
6767
.link-row {
6868
display: flex;
6969
flex-direction: column;
70-
71-
a {
72-
color: var(--color-brand);
73-
}
7470
}
7571
}
7672

lang/en.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"content.contributors.columned-hero.title": "These people are truly amazing...",
1515
"content.contributors.columned-hero.subtitle": "Fabulously Optimized is a community effort, and we couldn't have done it without these people.",
1616
"content.home.columned-hero.vanilla": "Manual download",
17-
"content.home.columned-hero.disclaimer": "By downloading Fabulously Optimized, you have acknowledged the disclaimers.",
17+
"content.home.columned-hero.disclaimer": "By downloading Fabulously Optimized, you have {0}.",
18+
"content.home.columned-hero.disclaimer.link": "acknowledged the disclaimers",
1819
"content.contributors.org": "Organization Members",
1920
"content.contributors": "Contributors",
2021
"content.home.columned-hero.title.supercharge": "Supercharge",

pages/contribute.vue

+17-4
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,21 @@ onMounted(() => {
126126

127127

128128
<style>
129-
body { font-family: BlinkMacSystemFont,-apple-system,"Segoe UI",Roboto,Oxygen,Ubuntu,Cantarell,"Fira Sans","Droid Sans","Helvetica Neue",Helvetica,Arial,sans-serif; }
130-
li img { width: 1em; height: 1em; margin-right: 0.5em; }
131-
a { color: var(--color-brand); text-decoration: none; }
132-
a:hover { text-decoration: underline; }
129+
body {
130+
font-family: BlinkMacSystemFont,-apple-system,"Segoe UI",Roboto,Oxygen,Ubuntu,Cantarell,"Fira Sans","Droid Sans","Helvetica Neue",Helvetica,Arial,sans-serif;
131+
}
132+
133+
li img {
134+
width: 1em; height: 1em; margin-right: 0.5em;
135+
}
136+
a {
137+
color: var(--color-brand); text-decoration: none;
138+
}
139+
html.dark a {
140+
color: var(--color-brand-dark);
141+
}
142+
143+
a:hover {
144+
text-decoration: underline;
145+
}
133146
</style>

pages/index.vue

+7-4
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,9 @@ const features: any = ref([
105105
</Button>
106106
</div>
107107
<div>
108-
<p id="disclaimer-text"><a href="/terms" target="_blank">{{ $t("content.home.columned-hero.disclaimer") }}</a></p>
108+
<i18n-t keypath="content.home.columned-hero.disclaimer" tag="p" id="disclaimer-text">
109+
<a href="/terms">{{ $t("content.home.columned-hero.disclaimer.link") }}</a>
110+
</i18n-t>
109111
</div>
110112
</div>
111113
<div class="column graph__container">
@@ -187,7 +189,9 @@ const features: any = ref([
187189
<Button :large="true" color="gray" @click="navigateTo(`/vanilla`, { external: true })">{{ $t("content.home.columned-hero.vanilla") }}</Button>
188190
</div>
189191
<div style="margin: -1em">
190-
<p id="disclaimer-text"><a href="/terms" target="_blank">{{ $t("content.home.columned-hero.disclaimer") }}</a></p>
192+
<i18n-t keypath="content.home.columned-hero.disclaimer" tag="p" id="disclaimer-text">
193+
<a href="/terms">{{ $t("content.home.columned-hero.disclaimer.link") }}</a>
194+
</i18n-t>
191195
</div>
192196
<!-- <DownloadSection class="download-card-fix" /> -->
193197
</div>
@@ -312,8 +316,7 @@ h3 {
312316
font-size: 0.6em;
313317
}
314318
315-
#disclaimer-text, #disclaimer-text > a{
319+
#disclaimer-text{
316320
color: gray;
317-
cursor: pointer;
318321
}
319322
</style>

0 commit comments

Comments
 (0)