New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic and code readability #1

Open

jgmurillo10 wants to merge 3 commits into FaisalST32:master from jgmurillo10:master

jgmurillo10 commented Sep 5, 2020

I wanted to start writing libraries, I found your blog (https://faisalrashid.tech/blogs/How-to-build-a-JavaScript-Library), started playing around with your code and ended overwriting some functions :) hope you don't mind.

Updated some logic that was being repetitive on images click.
Enhanced some readability.

jgmurillo10 added 3 commits

September 4, 2020 21:23


          Update coding standards

546cb4f


          Update logic

cbafcd3

* Handles all the lightbox within a wrapper.
* Best practices for coding style.
* Creates elements just on init.


          Fix spacing

bbdae37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet