Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arch's dependencies not properly handled by LLI binary #236

Closed
thw26 opened this issue Nov 26, 2024 · 0 comments · Fixed by #293
Closed

Arch's dependencies not properly handled by LLI binary #236

thw26 opened this issue Nov 26, 2024 · 0 comments · Fixed by #293
Labels
bug Something isn't working installer This issue is related to the install routine
Milestone
Release 4.0.0

Comments

@thw26
Copy link
Collaborator

thw26 commented Nov 26, 2024

Split from #143.
@thw26 thw26 added bug Something isn't working installer This issue is related to the install routine labels Nov 26, 2024
@ctrlaltf24 ctrlaltf24 mentioned this issue Feb 6, 2025
Merged
@thw26 thw26 linked a pull request Feb 6, 2025 that will close this issue
fix: remove pyinstaller from LD_LIBRARY_PATH when shelling out #293
Merged
ctrlaltf24 added a commit that referenced this issue Feb 6, 2025
@ctrlaltf24
fix: remove pyinstaller from LD_LIBRARY_PATH when shelling out (#293)
426d7c6 
Also remove need for manual dependency install steps (also caused by LD_LIBRARY_PATH)

Fixes: #292 #143 #236

Tested:
- running integration.run_cmd(["env") from a pyinstaller binary (with and with LD_LIBRARY_PATH set), observed LD_LIBRARY_PATH did not include tmpdir
- running system.run_command(["env") from a pyinstaller binary (with and with LD_LIBRARY_PATH set), observed LD_LIBRARY_PATH did not include tmpdir
- running system.run_command(["env") from a pyinstaller binary (without LD_LIBRARY_PATH set), observed LD_LIBRARY_PATH was not set
- clean install & run - login page showed successfully (install procedure calls popen_command, and run_command)
- built pyinstaller binary and ran on fedora 40 doing a clean install via TUI. login screen shown!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working installer This issue is related to the install routine
Projects
None yet
Milestone
Release 4.0.0
Development

Successfully merging a pull request may close this issue.

fix: remove pyinstaller from LD_LIBRARY_PATH when shelling out ctrlaltf24/OuDedetai
1 participant
@thw26