Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern conflict checking #466

Closed
object-Object opened this issue May 27, 2023 · 3 comments · Fixed by #612
Closed

Pattern conflict checking #466

object-Object opened this issue May 27, 2023 · 3 comments · Fixed by #612
Labels
1.20 api API-related enhancements/bugs/optimizations bug Something isn't working

Comments

@object-Object
Copy link
Member

Preface: I haven't checked if this is a thing in the new registry, but I wanted to open an issue so it doesn't get lost.

There should probably be a check when patterns are added to the registry to ensure that the given angle signature doesn't already exist and intentionally crash if it does. HexxyCraft recently had an issue where I backported bool_to_number, which has the same pattern as Hexal's type/iota. The game launched fine, and the only indication was the notebook failing to load with an obscure error message which only mentioned one of the patterns involved.

@gamma-delta
Copy link
Collaborator

Huh I swear I already impled that. Good catch

@object-Object object-Object changed the title Pattern overlap checking Pattern conflict checking Jun 7, 2023
@SamsTheNerd SamsTheNerd added bug Something isn't working needs decision labels Nov 11, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Hex Casting Jan 11, 2024
@object-Object object-Object added 1.20 needs investigation api API-related enhancements/bugs/optimizations and removed needs decision labels Jan 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Hex Casting - 1.20 Jan 11, 2024
@object-Object
Copy link
Member Author

@Talia-12 Do you know if this was implemented on 1.20?

@Talia-12
Copy link
Member

Talia-12 commented Feb 6, 2024

This seems like its now handled in a way that probablyy won't have unexpected behaviour like that, but doesn't let the user know that something's gone wrong (it is being added to a Map with the pattern signature as the key, and that map is what is used to recognise patterns). I'll make it do a warning to the console if it encounters a duplicate signature.

Talia-12 added a commit to Talia-12/HexMod that referenced this issue Feb 6, 2024
… the same signature (this won't catch great patterns that could overlap with regular/each other).
Talia-12 added a commit to Talia-12/HexMod that referenced this issue Feb 6, 2024
… the same signature (this won't catch great patterns that could overlap with regular/each other).
Talia-12 added a commit to Talia-12/HexMod that referenced this issue Feb 7, 2024
… the same signature (this won't catch great patterns that could overlap with regular/each other).
Talia-12 added a commit to Talia-12/HexMod that referenced this issue Feb 8, 2024
… the same signature (this won't catch great patterns that could overlap with regular/each other).
@object-Object object-Object moved this from 📋 Backlog to 👀 In review in Hex Casting Mar 25, 2024
@object-Object object-Object linked a pull request Mar 25, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Hex Casting May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 api API-related enhancements/bugs/optimizations bug Something isn't working
Projects
Status: ✅ Done
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants