-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern conflict checking #466
Comments
Huh I swear I already impled that. Good catch |
@Talia-12 Do you know if this was implemented on 1.20? |
This seems like its now handled in a way that probablyy won't have unexpected behaviour like that, but doesn't let the user know that something's gone wrong (it is being added to a Map with the pattern signature as the key, and that map is what is used to recognise patterns). I'll make it do a warning to the console if it encounters a duplicate signature. |
… the same signature (this won't catch great patterns that could overlap with regular/each other).
… the same signature (this won't catch great patterns that could overlap with regular/each other).
… the same signature (this won't catch great patterns that could overlap with regular/each other).
… the same signature (this won't catch great patterns that could overlap with regular/each other).
Preface: I haven't checked if this is a thing in the new registry, but I wanted to open an issue so it doesn't get lost.
There should probably be a check when patterns are added to the registry to ensure that the given angle signature doesn't already exist and intentionally crash if it does. HexxyCraft recently had an issue where I backported bool_to_number, which has the same pattern as Hexal's type/iota. The game launched fine, and the only indication was the notebook failing to load with an obscure error message which only mentioned one of the patterns involved.
The text was updated successfully, but these errors were encountered: