Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ambiguity around month "code" vs tag #570

Closed
dthaler opened this issue Nov 14, 2024 · 1 comment · Fixed by #571
Closed

ambiguity around month "code" vs tag #570

dthaler opened this issue Nov 14, 2024 · 1 comment · Fixed by #571

Comments

@dthaler
Copy link
Collaborator

dthaler commented Nov 14, 2024 •
edited
Loading

extensions.ged has an extension tag (_JOUR) with a standard calendar (FRENCH_R):

2 TAG _JOUR https://gedcom.io/terms/v7/month-COMP
...
2 CONT Standard month with an extTag            ... FRENCH_R 2 _JOUR 8
...
2 DATE BET FRENCH_R 2 _JOUR 8 AND _CALENDRIER 4 COMP 8

Section 2.4 (Date) of the GEDCOM spec says:

month   = stdTag / extTag  ; constrained by calendar

Section 6.1 (Known Calendars) says, under FRENCH_R:

Permitted months are:
(list that includes `COMP` but not `_JOUR`)

Taken together, this can be read as saying that the FRENCH_R calendar constrains the set of month tags as only permitting ones in the table in section 6.1, such that extension tags are not permitted.

Does the extensions.ged file have an invalid test case or does the spec need to be updated?
@dthaler
Copy link
Collaborator Author

dthaler commented Nov 19, 2024

Discussion during GEDCOM Steering Committee meeting 19 NOV 2024:
The following Section 6.1 text is relevant:

Month codes in extension calendars must either be already used for the same month name in another calendar or must start with _.
...
Each month defined in this section has a URI constructed by concatenating g7:month- to the month code; for example, the month of Elul has the URI http://gedcom.io/terms/v7/month-ELL.

  • We cannot find anywhere in the spec that says what the "month" production in ABNF refers to in the Known Calendars section. The text at the top of 6.1 says code is a URI suffix and says nothing about whether it's the same as a tag.
  • The text quoted above also only refers to months "defined in this section" and not a constraint on extension calendars.
  • We are thinking of changing the tables in section 6.1 to have 3 columns: standard tag, URI, and name (and getting rid of "code" as a term).

@dthaler dthaler transferred this issue from FamilySearch/GEDCOM.io Nov 19, 2024
@dthaler dthaler changed the title extensions.ged has questionable test case ambiguity around month "code" vs tag Nov 19, 2024
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
8267616 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
c72ab59 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
2cf884f 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
a3a727d 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
d60b411 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
4cca618 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Nov 19, 2024
@dthaler2
Remove "month code" as a term
e7c19f2 
Clarifies relationship with standard tags used in the ABNF

Fixes FamilySearch#570

Signed-off-by: Dave Thaler <[email protected]>
@dthaler dthaler mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "month code" as a term dthaler/GEDCOM
1 participant
@dthaler